You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
workflow_call.outputs.operation_completed was sourced only from jobs.run_operation.outputs.operation, but run_operation is skipped when dedicated jobs handle the operation (safe_outputs, create_labels, validate, clean_cache_memories). This meant callers would receive an empty operation_completed even though an operation ran.
Fix: Use ${{ jobs.run_operation.outputs.operation || inputs.operation }} so callers always get the operation that was requested/executed.
.github/workflows/agentics-maintenance.yml (generated output, updated to match)
Test improvement: scoped workflow_call assertion
The test was checking strings.Contains(yaml, "inputs:\n operation:") globally, which could pass from the workflow_dispatch block even if workflow_call was missing its operation input.
Fix: Slice the YAML from the workflow_call: index before checking for the operation input, making the assertion meaningful and specific.
Addresses review comments
r3079389620 — operation_completed fallback in Go template
r3079389710 — operation_completed fallback in generated YAML
The push was rejected because GitHub Actions does not have workflows permission to push these changes, and is never allowed to make such changes, or other authorization being used does not have this permission.
Create the pull request manually
# Download the patch from the workflow run
gh run download 24403856097 -n agent -D /tmp/agent-24403856097
# Create a new branch
git checkout -b cloclo/review-fixes-pr-26209-477b894a737aa607 main
# Apply the patch (--3way handles cross-repo patches)
git am --3way /tmp/agent-24403856097/aw-cloclo-review-fixes-pr-26209.patch
# Push the branch and create the pull request
git push origin cloclo/review-fixes-pr-26209-477b894a737aa607
gh pr create --title '[cloclo] fix: apply review feedback for workflow_call output and test scoping' --base main --head cloclo/review-fixes-pr-26209-477b894a737aa607 --repo github/gh-aw
🎤 Magnifique! Performance by /cloclo · ● 255.9K · ◷
Applies the review feedback from PR #26209.
Changes
Bug fix:
operation_completedoutput fallbackworkflow_call.outputs.operation_completedwas sourced only fromjobs.run_operation.outputs.operation, butrun_operationis skipped when dedicated jobs handle the operation (safe_outputs,create_labels,validate,clean_cache_memories). This meant callers would receive an emptyoperation_completedeven though an operation ran.Fix: Use
${{ jobs.run_operation.outputs.operation || inputs.operation }}so callers always get the operation that was requested/executed.Affects:
pkg/workflow/maintenance_workflow.go(template source).github/workflows/agentics-maintenance.yml(generated output, updated to match)Test improvement: scoped
workflow_callassertionThe test was checking
strings.Contains(yaml, "inputs:\n operation:")globally, which could pass from theworkflow_dispatchblock even ifworkflow_callwas missing itsoperationinput.Fix: Slice the YAML from the
workflow_call:index before checking for theoperationinput, making the assertion meaningful and specific.Addresses review comments
🤖 Generated with [Claude Code]((claude.com/redacted)
Warning
Protected Files — Push Permission Denied
This was originally intended as a pull request, but the patch modifies protected files. A human must create the pull request manually.
Protected files
The push was rejected because GitHub Actions does not have
workflowspermission to push these changes, and is never allowed to make such changes, or other authorization being used does not have this permission.Create the pull request manually