Skip to content

[q] fix: use scratchpad/architecture.md as cache source of truth #28421

@github-actions

Description

@github-actions

Fixes the caching issue in the daily architecture diagram workflow, as requested in #28412 by @pelikhan.

Problem

The workflow stored last_diagram inside architecture-state.json (cache-memory). When the workflow ran and the cache existed with a matching last_commit, it would call noop — even if scratchpad/architecture.md was empty or had incomplete content. This caused the run on 2026-04-25 to do a full rebuild when it shouldn't have needed to (the file wasn't being kept in sync with the cache).

Fix

  • Removed last_diagram from architecture-state.json — the cache now only stores last_commit and package_map
  • scratchpad/architecture.md is now the source of truth for the diagram — the workflow reads it directly to check if it exists and has content
  • Noop condition now checks both: no Go file changes since last_commit AND scratchpad/architecture.md exists with diagram content

Changes

  • .github/workflows/daily-architecture-diagram.md — updated Cache Strategy and Updating the Cache sections
  • .github/workflows/daily-architecture-diagram.lock.yml — recompiled

Validation

✅ Compiled successfully with agenticworkflows compile --workflows daily-architecture-diagram


Warning

Protected Files — Push Permission Denied

This was originally intended as a pull request, but the patch modifies protected files. A human must create the pull request manually.

Protected files

The push was rejected because GitHub Actions does not have workflows permission to push these changes, and is never allowed to make such changes, or other authorization being used does not have this permission.

Create the pull request manually
# Download the patch from the workflow run
gh run download 24928863169 -n agent -D /tmp/agent-24928863169

# Create a new branch
git checkout -b fix/architecture-cache-use-md-file-172f21aa774d0c85 main

# Apply the patch (--3way handles cross-repo patches)
git am --3way /tmp/agent-24928863169/aw-fix-architecture-cache-use-md-file.patch

# Push the branch and create the pull request
git push origin fix/architecture-cache-use-md-file-172f21aa774d0c85
gh pr create --title '[q] fix: use scratchpad/architecture.md as cache source of truth' --base main --head fix/architecture-cache-use-md-file-172f21aa774d0c85 --repo github/gh-aw

🎩 Equipped by Q · ● 3.6M ·

  • expires on Apr 27, 2026, 10:39 AM UTC

Metadata

Metadata

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions