Migrate 6 config parsers from unmarshalConfig to parseConfigScaffold

[github-actions]

Problem

Six safe-output config parsers in pkg/workflow still use the old manual unmarshalConfig pattern instead of the parseConfigScaffold generic scaffold introduced to abstract this pattern. This creates inconsistency: newer handlers like assign_to_agent.go and assign_to_user.go already use the scaffold correctly.

Affected Handlers

File	Function	Pattern
pkg/workflow/create_issue.go	parseIssuesConfig	manual unmarshalConfig + fallback
pkg/workflow/create_discussion.go	parseDiscussionsConfig	manual unmarshalConfig + fallback
pkg/workflow/create_pull_request.go	parsePullRequestsConfig	manual unmarshalConfig + fallback
pkg/workflow/add_comment.go	parseCommentsConfig	manual unmarshalConfig + fallback
pkg/workflow/add_reviewer.go	parseAddReviewerConfig	manual unmarshalConfig + fallback
pkg/workflow/close_entity_helpers.go	parseCloseEntityConfig	manual unmarshalConfig + fallback

Current Pattern (to replace)

// create_issue.go lines 58-64
var config CreateIssuesConfig
if err := unmarshalConfig(outputMap, "create-issue", &config, createIssueLog); err != nil {
    createIssueLog.Printf("Failed to unmarshal config: %v", err)
    // For backward compatibility, handle nil/empty config
    config = CreateIssuesConfig{}
}

Target Pattern (already used in assign_to_agent.go, assign_to_user.go)

config := parseConfigScaffold(outputMap, "create-issue", createIssueLog, func(err error) *CreateIssuesConfig {
    createIssueLog.Printf("Failed to unmarshal config: %v", err)
    return &CreateIssuesConfig{}
})

Migration Notes

These handlers have preprocessing steps (preprocessBoolFieldAsString, preprocessIntFieldAsString) that must run before parseConfigScaffold. Since the preprocessing mutates the config sub-map in-place, the correct migration is:

1. Extract configData, _ := outputMap["key"].(map[string]any) (nil-safe, no-op if absent)
2. Run all preprocessing on configData
3. Call parseConfigScaffold (returns nil if key absent — correct behaviour)

This is exactly the pattern in assign_to_user.go:19-47.

Recommendation

For each of the 6 handlers:

1. Add the key existence + configData extraction before preprocessing
2. Replace the if err := unmarshalConfig(...) block with parseConfigScaffold(...)
3. Keep all preprocessing unchanged

Severity

• Medium — consistency/maintainability, no runtime behavior change

Validation

• go build ./pkg/workflow/ passes
• go test ./pkg/workflow/... passes
• Each migrated handler produces identical behavior to before

Generated by Sergo - Serena Go Expert · ● 901.5K · ◷

• expires on May 3, 2026, 8:34 PM UTC

[github-actions]

🍪 *Issue Monster selected this for Copilotecho BEGIN___COMMAND_OUTPUT_MARKER ; PS1= ; PS2= ; unset HISTFILE ; EC=0 ; echo ___BEGIN___COMMAND_DONE_MARKER___0 ; }

I've identified this issue as a good candidate for automated resolution and requested assignment to the Copilot coding agent.

If assignment succeeds, the Copilot coding agent will analyze the issue and create a pull request with the fix.

Om nom nom! 🍪

Caution

Security scanning requires review for Issue Monster

Details

Potential security threats were detected in the agent output. The workflow output should be reviewed before merging.

Review the workflow run logs for details.

🍪 Om nom nom by Issue Monster · ● 17.3K · ◷