You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is an agentic implementation plan for a small, low-risk documentation/test improvement related to #28716: strengthen coverage for table scroll wrapper consistency on /reference/engines/.
Per CONTRIBUTING.md, non-core contributors should not open traditional pull requests. This issue is intended for a core team member or their coding agent to implement as a small docs/test-only change.
Issue selection notes
Confirmed there are currently no open issues labeled good first issue.
Confirmed there are currently no open issues labeled help wanted.
Focused on one minimal improvement from the report: table scroll wrapper consistency for the engines reference page.
Reproduction / audit notes
Relevant files found during audit:
docs/src/content/docs/reference/engines.md contains the /reference/engines/ documentation source.
docs/src/lib/rehype/tableWrapper.js wraps markdown tables in <div class="table-scroll-wrapper"> at build time.
docs/astro.config.mjs registers rehypeTableWrapper in the Astro markdown pipeline.
docs/tests/mobile-responsive.spec.ts already has a no-JavaScript table wrapper smoke test, but it only checks the first wrapper/table.
This means the implementation appears to already provide a framework-level wrapper, but the regression test can be made more precise by verifying every rendered table on /reference/engines/ is directly wrapped, not just the first table.
Proposed minimal change
Update only docs/tests/mobile-responsive.spec.ts.
Replace the existing test named should wrap markdown tables in a scroll wrapper without JavaScript with a stronger assertion that:
Loads /gh-aw/reference/engines/ with JavaScript disabled.
Locates all rendered .sl-markdown-content table elements.
Asserts at least one table is present.
Iterates through every table and asserts its direct parent has the table-scroll-wrapper class.
Keeps the existing no-JavaScript coverage so the test validates build-time behavior rather than client-side mutation.
Example implementation shape for the core team agent:
test('should wrap every engines reference table in a scroll wrapper without JavaScript',async({ browser })=>{constcontext=awaitbrowser.newContext({javaScriptEnabled: false,viewport: {width: 768,height: 1024},});constpage=awaitcontext.newPage();awaitpage.goto('/gh-aw/reference/engines/');awaitpage.waitForLoadState('domcontentloaded');consttables=page.locator('.sl-markdown-content table');consttableCount=awaittables.count();expect(tableCount).toBeGreaterThan(0);for(letindex=0;index<tableCount;index++){constparentClass=awaittables.nth(index).evaluate((table)=>table.parentElement?.className??'');expect(parentClass).toContain('table-scroll-wrapper');}awaitcontext.close();});
This keeps the change limited to tests and avoids touching product behavior, workflow execution logic, security-sensitive code, or broad formatting.
Validation plan for the implementation PR
Recommended checks for the core team implementation:
cd docs && npm test -- --grep "wrap every engines reference table" or the repository-equivalent Playwright test command for docs/tests/mobile-responsive.spec.ts.
cd docs && npm run build if available in the Dev Container/Codespace.
make agent-finish from the repository root in the provided Dev Container or Codespace.
Validation performed for this plan
Reviewed CONTRIBUTING.md and confirmed non-core contributors should create agentic plan issues instead of pull requests.
Audited docs files for table wrapper and touch-target related implementation.
Considered make agent-finish; if not in a Dev Container/Codespace, it was not run and the environment limitation was recorded in agent-finish-28716.log.
Scope guardrails
Do not change primary navigation behavior.
Do not change workflow execution logic.
Do not change security-sensitive code.
Do not apply broad formatting.
Keep the implementation to documentation UI tests unless the core team finds during implementation that the table wrapper itself is missing for a rendered table.
Command considered: make agent-finish
Started: 2026-04-27T12:59:59Z
Environment markers:
CODESPACES=
/.dockerenv absent
/workspaces absent
--- decision ---
Not running make agent-finish because this workspace is not a Dev Container or Codespace. Repository CONTRIBUTING/Makefile recommend running this target in the provided Dev Container/Codespace; running it directly in the host environment previously exceeded the agent command budget.
Finished: 2026-04-27T12:59:59Z
Summary
This is an agentic implementation plan for a small, low-risk documentation/test improvement related to #28716: strengthen coverage for table scroll wrapper consistency on
/reference/engines/.Per
CONTRIBUTING.md, non-core contributors should not open traditional pull requests. This issue is intended for a core team member or their coding agent to implement as a small docs/test-only change.Issue selection notes
good first issue.help wanted.Reproduction / audit notes
Relevant files found during audit:
docs/src/content/docs/reference/engines.mdcontains the/reference/engines/documentation source.docs/src/lib/rehype/tableWrapper.jswraps markdown tables in<div class="table-scroll-wrapper">at build time.docs/astro.config.mjsregistersrehypeTableWrapperin the Astro markdown pipeline.docs/tests/mobile-responsive.spec.tsalready has a no-JavaScript table wrapper smoke test, but it only checks the first wrapper/table.This means the implementation appears to already provide a framework-level wrapper, but the regression test can be made more precise by verifying every rendered table on
/reference/engines/is directly wrapped, not just the first table.Proposed minimal change
Update only
docs/tests/mobile-responsive.spec.ts.Replace the existing test named
should wrap markdown tables in a scroll wrapper without JavaScriptwith a stronger assertion that:/gh-aw/reference/engines/with JavaScript disabled..sl-markdown-content tableelements.table-scroll-wrapperclass.Example implementation shape for the core team agent:
This keeps the change limited to tests and avoids touching product behavior, workflow execution logic, security-sensitive code, or broad formatting.
Validation plan for the implementation PR
Recommended checks for the core team implementation:
cd docs && npm test -- --grep "wrap every engines reference table"or the repository-equivalent Playwright test command fordocs/tests/mobile-responsive.spec.ts.cd docs && npm run buildif available in the Dev Container/Codespace.make agent-finishfrom the repository root in the provided Dev Container or Codespace.Validation performed for this plan
CONTRIBUTING.mdand confirmed non-core contributors should create agentic plan issues instead of pull requests.good first issueorhelp wantedissues before selecting 🔍 Multi-Device Docs Testing Report - 2026-04-27 #28716.make agent-finish; if not in a Dev Container/Codespace, it was not run and the environment limitation was recorded inagent-finish-28716.log.Scope guardrails
Related: #28716
Local validation log
Command considered: make agent-finish
Started: 2026-04-27T12:59:59Z
Environment markers:
CODESPACES=
/.dockerenv absent
/workspaces absent
--- decision ---
Not running make agent-finish because this workspace is not a Dev Container or Codespace. Repository CONTRIBUTING/Makefile recommend running this target in the provided Dev Container/Codespace; running it directly in the host environment previously exceeded the agent command budget.
Finished: 2026-04-27T12:59:59Z