-
Notifications
You must be signed in to change notification settings - Fork 298
Closed
Labels
Description
Objective
Fix 10 occurrences of shellcheck SC2086 info-level issues across 5 workflows by adding proper quotes around variable references.
Problem
Unquoted variables can lead to unexpected word splitting or pathname expansion:
echo $variable # ❌ Can split on whitespace, expand globs
command $arg # ❌ May cause unexpected behaviorSolution
Add double quotes:
echo "$variable" # ✅ Preserves spaces, prevents expansion
command "$arg" # ✅ Treats as single argumentWhy This Matters
- Prevents word splitting on spaces/tabs/newlines
- Prevents glob expansion (*, ?, etc.)
- Ensures variables are treated as single arguments
- Makes script behavior more predictable
Approach
- Search for unquoted variable usage:
grep -n '\$[A-Za-z_]' .github/workflows/*.md - Identify the 10 specific SC2086 violations from actionlint output
- Add quotes around each variable reference
- Recompile workflows:
make recompile - Verify with actionlint
Files to Modify
5 workflow .md files in .github/workflows/ (10 total occurrences)
Acceptance Criteria
- All 10 SC2086 issues resolved
- Variables properly quoted throughout
-
actionlintshows 0 SC2086 issues - No change in intended functionality
Related to [plan] Address static analysis findings from actionlint/shellcheck #7896
AI generated by Plan Command for discussion #7889
Reactions are currently unavailable