[plan] Migrate spinner usage and remove old implementation

[github-actions]

Objective

Migrate all usage of the old spinner to the new idiomatic implementation and remove the deprecated code.

Context

Once the new spinner is implemented, tested, and documented, we need to:

1. Find all usages of the old spinner
2. Update them to use the new implementation
3. Verify everything still works
4. Remove the old code

Approach

1. Search for all imports and usages of spinner in the codebase
2. Update each usage to use the new spinner API
3. Run all tests to verify behavior
4. Rename spinner_v2.go to spinner.go
5. Delete old implementation

Files to Modify

• Search: All files using console.SpinnerWrapper or console.NewSpinner
• Update: Each file using spinner
• Rename: pkg/console/spinner_v2.go → pkg/console/spinner.go
• Delete: Old pkg/console/spinner.go (after migration)

Migration Checklist

• Find all spinner usages with grep -r "NewSpinner\|SpinnerWrapper"
• Update each usage to new API (if different)
• Run unit tests: make test-unit
• Run full tests: make test
• Verify manual testing with real spinner scenarios
• Rename spinner_v2.go to spinner.go
• Remove old implementation
• Run make agent-finish before committing

Acceptance Criteria

• All spinner usages migrated to new implementation
• All tests pass (unit + integration)
• Old implementation removed
• No references to old spinner remain
• Manual testing confirms spinner works in terminal
• Code builds and lints successfully
  Related to [plan] Refactor spinner to use idiomatic Bubble Tea pattern #9189

AI generated by Plan Command for discussion #9188