Correct PR description: YAML context not shell injection in code scanning alert #538#11426
Merged
pelikhan merged 1 commit intofix/code-scanning-alert-538-remove-dead-code-4aa93f2b3d92ad6dfrom Jan 23, 2026
Conversation
Copilot
AI
changed the title
[WIP] Fix unsafe quoting in YAML environment variable
Correct PR description: YAML context not shell injection in code scanning alert #538
Jan 23, 2026
pelikhan
merged commit ba457fa
into
fix/code-scanning-alert-538-remove-dead-code-4aa93f2b3d92ad6d
1 check passed
This was referenced Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original PR description incorrectly characterized CodeQL alert #538 as a shell injection vulnerability. The code was generating YAML environment variables, not executing shell commands.
Context Correction
The flagged code in
update_project_job.go(lines 42-52):%qformatting to embed JSON in YAML environment variable declarationslgtm[go/unsafe-quoting]explaining it generates YAML, not shell commands%qescaping doesn't match YAML quoting rules, potentially breaking YAML parsingFix Remains Valid
The
GH_AW_PROJECT_VIEWSenvironment variable was never consumed anywhere:pkg/workflow/js/*.cjs)GH_AW_SAFE_OUTPUTS_PROJECT_HANDLER_CONFIG(compiler_safe_outputs_config.go:602-608)The code change (removing unused env var generation +
encoding/jsonimport) is correct. Only the PR description's threat model characterization needed correction.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.