Fix smoke test workflows not removing smoke label#11429
Merged
pelikhan merged 2 commits intocopilot/review-remove-label-safe-outputfrom Jan 23, 2026
Merged
Fix smoke test workflows not removing smoke label#11429pelikhan merged 2 commits intocopilot/review-remove-label-safe-outputfrom
smoke label#11429pelikhan merged 2 commits intocopilot/review-remove-label-safe-outputfrom
Conversation
This was referenced Jan 23, 2026
- Update smoke-copilot.md to explicitly mention using remove_labels safe-output tool - Update smoke-codex.md to consistently use remove_labels tool - Recompile workflows to apply changes The issue was that the prompt said "Remove the label `smoke`" but didn't explicitly tell the agent to use the `remove_labels` safe-output tool. Making this explicit ensures the agent knows which tool to call. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Debug smoke label removal by safe-outputs tool
Fix smoke test workflows not removing Jan 23, 2026
smoke label
pelikhan
approved these changes
Jan 23, 2026
This was referenced Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Smoke test workflows added engine-specific labels (
smoke-copilot,smoke-codex) but failed to remove the triggeringsmokelabel. Agent logs showedadd_labelscalls but noremove_labelscalls despite prompt instructions.Changes
Explicit tool calls in prompts
Agent didn't recognize implicit instructions like "Remove the label" as requiring the
remove_labelssafe-output tool.Before:
After:
Files updated
smoke-copilot.md/smoke-codex.md- Explicit tool names in prompt.lock.ymlfiles - Recompiled workflowsBoth workflows had
remove-labelsconfigured in safe-outputs but only copilot mentioned removal in the prompt. Now both explicitly name the tools.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.