Conversation
- Add support for rendering allowed_tools field in GitHub MCP remote config when IncludeToolsField is true - Add float64 case to reaction parser to handle YAML parsing of +1/-1 as numbers Fixes: - TestRenderGitHubMCPRemoteConfigToolsCommas now passes - TestNumericReactionParsing now passes
pelikhan
approved these changes
Jan 24, 2026
pelikhan
deleted the
ci-cleaner-fixes-20260124-062008-71b71f30d2c9cb46
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two test failures discovered during CI cleanup:
1. GitHub MCP allowed_tools rendering
Fixed:
TestRenderGitHubMCPRemoteConfigToolsCommasThe
RenderGitHubMCPRemoteConfigfunction now properly honors theIncludeToolsFieldandAllowedToolsoptions. WhenIncludeToolsFieldis true andAllowedToolsis provided, the function now renders thetoolsarray in the GitHub MCP remote configuration with proper comma separation.Changes:
pkg/workflow/mcp_renderer.go: Added logic to render thetoolsfield when requested, with proper JSON array formatting including commas between items and no comma after the last item2. Numeric reaction parsing
Fixed:
TestNumericReactionParsingThe reaction parser now handles YAML's behavior of parsing unquoted
+1and-1as float64 numbers.Changes:
pkg/workflow/reactions.go: Addedfloat64case toparseReactionValue()to convert1.0to "+1" and-1.0to "-1"Test Results
Both previously failing tests now pass:
TestRenderGitHubMCPRemoteConfigToolsCommasTestNumericReactionParsingContext
The CI cleaner workflow was triggered but no specific CI failures were indicated in the run parameters (empty
ci_statusandci_run_id). The working tree was clean initially. These fixes address real test failures that were discovered during the automated cleanup process.Note
There are additional test failures in the repository related to GitHub MCP configuration architecture changes (change from
type: localtotype: stdiowith containers), but those appear to be part of a larger ongoing refactoring and are outside the scope of this automated CI cleanup.