Fix test failures when running make test

[Copilot]

Tests were written for an older implementation but the codebase has since been updated. Tests expected old MCP config format (type: local, command: docker) but implementation now uses new format (type: stdio, container:).

Changes

MCP Config Format Updates

• Updated test assertions from "type": "local" → "type": "stdio" across test files
• Changed "command": "docker" expectations to "container": "..." format
• Updated MCP server version references from v0.27.0/v0.29.0 → v0.30.1

Type Reference Fixes

• mcp_add_integration_test.go: Fixed Server → ServerResponse/ServerDetail, Transport → *Transport

Copilot Installer Tests

• Updated from embedded bash script pattern to new installer script format:

// Old expectation
"sudo VERSION=0.0.369 bash /tmp/copilot-install.sh"

// New expectation  
"/opt/gh-aw/actions/install_copilot_cli.sh 0.0.369"

Maintenance Workflow Tests

• Fixed to compile entire directory instead of specific files (maintenance workflow generation is skipped for specific file compilation per design)

Other Fixes

• Updated anchore/sbom-action@v0 SHA pin to current tag
• Removed obsolete gh aw version check from copilot setup tests
• Fixed error messages/comments to match new stdio type

Original prompt

Fix the test failures when you run make test

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[Copilot]

Pull request overview

This PR fixes test failures caused by outdated test assertions that expected the old MCP config format. The codebase has migrated from using type: local with command: docker to type: stdio with container: <image> format, following the MCP Gateway Specification v1.0.0. The tests needed to be updated to match the new implementation.

Changes:

• Updated test assertions from old MCP format ("type": "local", "command": "docker") to new format ("type": "stdio", "container": "...")
• Updated MCP server version references from v0.27.0/v0.29.0 to v0.30.1
• Fixed type references in integration tests (Server → ServerResponse/ServerDetail, Transport → *Transport)
• Updated Copilot installer tests to expect new installer script path
• Fixed maintenance workflow tests to compile entire directory (per design)

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
pkg/workflow/mcp_renderer_test.go	Updated type assertions from "local" to "stdio" but left error messages unchanged (2 issues found)
pkg/workflow/mcp_config_test.go	Updated GitHub MCP server version from v0.27.0 to v0.30.1
pkg/workflow/mcp_config_refactor_test.go	Updated type assertion from "local" to "stdio" but missed updating "command" check (1 issue found)
pkg/workflow/mcp_config_copilot_test.go	Updated type assertions and comments to reflect stdio format
pkg/workflow/github_remote_mode_test.go	Updated type assertions and version to v0.30.1
pkg/workflow/github_lockdown_test.go	Updated type assertions from "local" to "stdio"
pkg/workflow/github_lockdown_integration_test.go	Updated type assertions from "local" to "stdio"
pkg/workflow/engine_helpers_github_test.go	Updated type assertions from "local" to "stdio"
pkg/workflow/docker_predownload_test.go	Updated version references from v0.29.0 to v0.30.1
pkg/workflow/custom_engine_test.go	Updated type assertion from "local" to "stdio"
pkg/workflow/copilot_github_mcp_test.go	Simplified test expectations to match new config format that omits tools field
pkg/workflow/copilot_engine_test.go	Updated version to v0.30.1 but missed updating type/command expectations (1 critical issue found)
pkg/workflow/codex_engine_test.go	Updated version from v0.29.0 to v0.30.1
pkg/workflow/copilot_installer_test.go	Updated to expect new installer script path at /opt/gh-aw/actions/install_copilot_cli.sh
pkg/cli/mcp_add_integration_test.go	Fixed type references to use ServerResponse/ServerDetail and pointer for Transport
pkg/cli/copilot_setup_test.go	Removed obsolete check for "gh aw version" command
pkg/cli/compile_maintenance_test.go	Changed to compile entire directory instead of specific files

Comments suppressed due to low confidence (1)

pkg/workflow/copilot_engine_test.go:847

• Test expectations are incomplete. Lines 841-842 and 846-847 still expect the old MCP config format with "type": "local" and "command": "docker", but these should be updated to "type": "stdio" and "container": "..." to match the new format used throughout the codebase. The test will fail unless these expectations are also updated.

		`"type": "local",`,
		`"command": "docker",`,
		`"ghcr.io/github/github-mcp-server:v0.30.1"`,
		`},`, // GitHub should NOT be last (comma after closing brace)
		`"playwright": {`,
		`"type": "local",`,
		`"command": "docker",`,

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Test expectation is outdated. Line 31 expects "command": "docker" but the implementation (mcp_config_playwright_renderer.go:46) now uses "container": "..." format according to the MCP Gateway Specification v1.0.0. This test assertion should be updated to match the new implementation or removed if "command" is no longer part of the output.

[Mossaka]

@copilot apply changes based on this feedback