Skip to content

Fix Security Guard Agent to call noop when no security concerns found #12086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 3 commits into from
Jan 27, 2026
Merged

Fix Security Guard Agent to call noop when no security concerns found #12086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82a4eac
Initial plan
Copilot Jan 27, 2026
6dff563
Fix Security Guard Agent to call noop when no security concerns found
Copilot Jan 27, 2026
4d6f53e
Merge branch 'main' into copilot/debug-security-guard-agent
Mossaka Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/security-guard.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 7 additions & 6 deletions .github/workflows/security-guard.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ tools:
safe-outputs:
add-comment:
max: 1
noop:
messages:
footer: "> 🛡️ *Security posture analysis by [{workflow_name}]({run_url})*"
run-started: "🔒 [{workflow_name}]({run_url}) is analyzing this pull request for security posture changes..."
Expand Down Expand Up @@ -139,7 +140,7 @@ For each changed file:

**CRITICAL DECISION**: After analysis, determine if there are ANY concrete security concerns:

- **NO SECURITY CONCERNS FOUND**: Exit gracefully WITHOUT commenting. Do not call `add_comment`.
- **NO SECURITY CONCERNS FOUND**: Call `noop` to explicitly signal that no security issues were detected. Do not call `add_comment`.
- **SECURITY CONCERNS FOUND**: Proceed to Step 4 to create a comment with evidence.

### Step 4: Create Security Report (Only if concerns found)
Expand Down Expand Up @@ -198,15 +199,15 @@ Do not comment on:

### Scenario A: Safe PR (No Comment)
PR adds a new feature with no security-relevant changes.
→ **Action**: Exit without commenting. Do NOT call `add_comment`.
→ **Action**: Call `noop` to signal no concerns. Do NOT call `add_comment`.

### Scenario B: Security Improvement (No Comment)
PR adds input validation or restricts permissions.
→ **Action**: Exit without commenting. The PR improves security.
→ **Action**: Call `noop` to signal no concerns. The PR improves security.

### Scenario C: Justified Security Change (No Comment)
PR expands network access with clear justification in description.
→ **Action**: Exit without commenting. Let the author's justification stand.
→ **Action**: Call `noop` to signal no concerns. Let the author's justification stand.

### Scenario D: Security Concern Found (Comment)
PR adds `sandbox.agent: false` without explanation.
Expand All @@ -218,7 +219,7 @@ PR adds `sandbox.agent: false` without explanation.

- Be thorough in your analysis
- Be precise in your evidence
- Be silent when there are no concerns
- Call `noop` when there are no concerns to explicitly signal completion
- Be helpful when there are concerns

When in doubt about whether something is a security issue, lean toward NOT commenting. Only flag issues you can prove with concrete evidence from the diff.
When in doubt about whether something is a security issue, lean toward calling `noop`. Only flag issues you can prove with concrete evidence from the diff.
Loading