Replace redundant zero-capacity slice allocations with idiomatic zero-value declarations

[Copilot]

Replace make([]T, 0) with var slice []T across 8 instances in the workflow compilation pipeline. Zero-value slices are idiomatic Go and eliminate unnecessary allocations.

Changes

• pkg/workflow/action_cache.go: 3 slices (toDelete, deduplicationDetails, removedVersions)
• pkg/workflow/jobs.go: 2 slices (jobOrder initialization removed, queue)
• pkg/workflow/mcp_setup_generator.go: 1 slice (envVarNames)
• pkg/workflow/compiler_safe_outputs_job.go: 1 slice (newSteps)
• pkg/workflow/step_order_validation.go: 1 slice (steps initialization removed)

Before:

envVarNames := make([]string, 0)
for _, name := range vars {
    envVarNames = append(envVarNames, name)
}

After:

var envVarNames []string
for _, name := range vars {
    envVarNames = append(envVarNames, name)
}

No behavior change—nil slices work identically with append.

Original prompt

---

This section details on the original issue you should resolve

<issue_title>[plan] Eliminate redundant zero-capacity slice allocations</issue_title>
<issue_description>## Objective

Replace 10 instances of redundant make([]T, 0) allocations with idiomatic zero-value slices.

Context

From discussion githubnext/gh-aw#12006: Sergo analysis found explicit zero-capacity slice allocations that are less idiomatic and create unnecessary overhead. Zero-value slices work perfectly with append and are the Go convention.

Files to Modify

• pkg/workflow/mcp_setup_generator.go:607
• pkg/workflow/jobs.go:48, 432
• pkg/workflow/action_cache.go:241, 242, 279
• pkg/workflow/compiler_safe_outputs_job.go:372
• pkg/workflow/step_order_validation.go:42

Approach

Replace patterns like:

envVarNames := make([]string, 0)
for _, name := range vars {
    envVarNames = append(envVarNames, name)
}

With idiomatic Go:

var envVarNames []string
for _, name := range vars {
    envVarNames = append(envVarNames, name)
}

Acceptance Criteria

• All 10 instances replaced with zero-value slice declarations
• All existing tests pass
• Code passes go vet and golangci-lint
• No behavior changes (nil slices work identically with append)

AI generated by Plan Command for discussion #12006

Comments on the Issue (you are @copilot in this section)

• Fixes [plan] Eliminate redundant zero-capacity slice allocations #12178

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[github-actions]

🔍 PR Triage Results

Category: refactor | Risk: low | Priority: 43/100

Scores Breakdown

• Impact: 22/50 - Code quality improvement through idiomatic Go conventions
• Urgency: 12/30 - Very recent PR (<1 hour old), CI showing some feedback
• Quality: 9/20 - Draft status, CI unstable but providing feedback

📋 Recommended Action: defer

Rationale: This PR is in draft state and should remain deferred until marked ready for review. The changes are low-risk (only 16 lines changed across 5 files) and improve code quality by replacing make([]T, 0) with idiomatic zero-value slices. Once out of draft, this will be a good candidate for fast-track review given its focused scope and clear benefits.

Next steps: Mark as ready for review when CI is stable and all acceptance criteria are met.

---

Triaged by PR Triage Agent on 2026-01-28

AI generated by PR Triage Agent