Skip to content

Add support for expires: false to disable expiration in safe-outputs#12311

Merged
pelikhan merged 4 commits intomainfrom
copilot/add-expiration-support
Jan 28, 2026
Merged

Add support for expires: false to disable expiration in safe-outputs#12311
pelikhan merged 4 commits intomainfrom
copilot/add-expiration-support

Conversation

Copy link
Contributor

Copilot AI commented Jan 28, 2026

Safe-outputs for create-discussion and create-issue now support expires: false to explicitly disable automatic expiration.

Changes

  • Schema: Added boolean false as valid expires value in main_workflow_schema.json
  • Parser: parseExpiresFromConfig() returns -1 sentinel for false, enabling distinction from unset/invalid values
  • Config parsing: Detects -1 to skip default expiration (create-discussion's 7-day default)
  • Config generation: Omits expires field from handler config JSON when value is 0 (disabled)
  • Tests: Added coverage for boolean false case
  • Workflow Update: Applied expires: false to agent-persona-explorer.md workflow's create-discussion configuration

Example

safe-outputs:
  create-discussion:
    expires: false  # No expiration
  create-issue:
    expires: 7      # 168 hours (7 days * 24)

Compiles to:

{
  "create_discussion": {"max": 1},
  "create_issue": {"expires": 168, "max": 1}
}

The expires field is completely omitted when disabled, and no GH_AW_*_EXPIRES environment variables are set.

Original prompt

Add support for safe-outputs.create-discussion.expires: false to disable expiration in create discussions.
Do the same for safe-outputs.create-issue.expires: false


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits January 28, 2026 17:24
…sion and create-issue

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan
Copy link
Contributor

@copilot disable expires on agent persona explorer safe-outputs.create-discussion

Copilot AI changed the title [WIP] Add support for disabling expiration in create discussions and issues Add support for expires: false to disable expiration in safe-outputs Jan 28, 2026
Copilot AI requested a review from pelikhan January 28, 2026 17:41
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 28, 2026

@copilot disable expires on agent persona explorer safe-outputs.create-discussion

Done. Added expires: false to the agent-persona-explorer workflow's create-discussion configuration. The discussions created by this workflow will no longer have automatic expiration. (commit be9476c)

@github-actions
Copy link
Contributor

🔍 PR Triage Results

Category: feature | Risk: high | Priority: 52/100

Scores Breakdown

  • Impact: 35/50 - New feature adds valuable functionality
  • Urgency: 7/30 - Standard feature development timeline
  • Quality: 10/20 - Has description and pending CI validation

📋 Recommended Action: batch_review

This PR is part of batch-feature-high (6 PRs) - high-risk feature additions requiring careful review. Should be reviewed in priority order with attention to test coverage and security implications.

Batch PRs: #12322, #12321, #12320, #12311, #12130, #12085


Triaged by PR Triage Agent on 2026-01-28T18:16:26Z

AI generated by PR Triage Agent

@pelikhan pelikhan merged commit 92f4dca into main Jan 28, 2026
123 of 124 checks passed
@pelikhan pelikhan deleted the copilot/add-expiration-support branch January 28, 2026 19:11
github-actions bot added a commit that referenced this pull request Jan 28, 2026
Add documentation for the new expires: false feature added in PR #12311.
This feature allows explicitly disabling auto-expiration for create-issue
and create-discussion safe-outputs.

Changes:
- Update Auto-Expiration section to mention expires: false option
- Update create-issue and create-discussion examples
- Clarify that expires supports integers, relative formats, or false

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
pelikhan pushed a commit that referenced this pull request Jan 28, 2026
Add documentation for the new expires: false feature added in PR #12311.
This feature allows explicitly disabling auto-expiration for create-issue
and create-discussion safe-outputs.

Changes:
- Update Auto-Expiration section to mention expires: false option
- Update create-issue and create-discussion examples
- Clarify that expires supports integers, relative formats, or false

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants