ci-coach: Add test integrity safeguards and canary job integration#12406
Merged
ci-coach: Add test integrity safeguards and canary job integration#12406
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
- Add canary job output instructions to detect missing tests - Add test suite integrity validation requirements - Add strict prohibition against modifying test code to hide errors - Ensure CI Coach never swallows errors or suppresses test failures Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update CI coach agentic workflow to improve error handling
ci-coach: Add test integrity safeguards and canary job integration
Jan 29, 2026
pelikhan
approved these changes
Jan 29, 2026
This was referenced Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ci-coach workflow lacked explicit guardrails against anti-patterns (swallowing test errors, ignoring failures) and wasn't leveraging the canary job's test coverage analysis.
Changes
Phase 2: Test Coverage Analysis
test-coverage-analysisartifact comparingall-tests.txtvsexecuted-tests.txtto identify missing tests in CI matrixImportant Guidelines: Test Code Integrity
Added critical section prohibiting:
|| true,set +e,|| echo "ignoring")Explicit DO/DON'T guidance: fix root cause → ✅ | suppress errors → ❌
Safety Checks
Reinforced test integrity requirements in validation checklist.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.