Skip to content

Fix unused code linting errors in workflow package#12443

Merged
pelikhan merged 4 commits intomainfrom
copilot/lint-go-code-yet-again
Jan 29, 2026
Merged

Fix unused code linting errors in workflow package#12443
pelikhan merged 4 commits intomainfrom
copilot/lint-go-code-yet-again

Conversation

Copy link
Contributor

Copilot AI commented Jan 29, 2026

Resolved 5 unused code warnings from golangci-lint in the workflow package.

Changes

Removed unused code:

  • getGitHubRepoURL() - duplicate helper in action_pins_test.go (integration tests use getGitHubRepoURLIntegration())
  • autoEnabledHandlers - unused map in compiler_safe_outputs_config.go
  • renderPlaywrightMCPConfigTOML() - unused TOML renderer in mcp_config_playwright_renderer.go

Added nolint directives:

  • buildCreateOutputPullRequestReviewCommentJob() - used in integration tests with //go:build integration tag
  • getCreatePRReviewCommentScript() - returns empty string post-embedded-script-removal but still called

The linter flags these as unused because it doesn't process integration build tags by default and considers empty-string-returning functions as dead code despite being invoked.

Original prompt

Lint go

Custom agent used: ci-cleaner
Tidies up the repository CI state by formatting sources, running linters, fixing issues, running tests, and recompiling workflows


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 2 commits January 29, 2026 04:40
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Add linter for Go code Fix unused code linting errors in workflow package Jan 29, 2026
Copilot AI requested a review from pelikhan January 29, 2026 04:46
@pelikhan pelikhan marked this pull request as ready for review January 29, 2026 04:47
@pelikhan pelikhan merged commit 4c290cb into main Jan 29, 2026
50 checks passed
@pelikhan pelikhan deleted the copilot/lint-go-code-yet-again branch January 29, 2026 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants