Ignore safe-outputs.jobs messages in handler managers#13064
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
| * These are job names defined in safe-outputs.jobs that are processed by custom jobs | ||
| * @returns {Set<string>} Set of custom safe output job type names | ||
| */ | ||
| function loadCustomSafeOutputJobTypes() { |
There was a problem hiding this comment.
@copilot move to helper file for safe output jobs
There was a problem hiding this comment.
Moved loadCustomSafeOutputJobTypes() to safe_output_helpers.cjs and updated both handler managers to import it from the shared helper file. Tests were also moved to safe_output_helpers.test.cjs for centralized testing. Commit 59ec8b2
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot merge main and recompile |
|
🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰 |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
Agent Container Tool Smoke Test
Result: 10/12 tools available ❌ Missing Tools:
Available Core Tools: ✅
|
|
PRs: Add Serena MCP tool usage statistical analysis with request/response size metrics | Merge main branch and recompile workflows
|
Smoke Test ResultsPRs Tested:
Test Results:
Overall Status: PASS
|
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
Summary
Fixed an issue where messages from custom safe output jobs (defined in
safe-outputs.jobs) were incorrectly triggering warnings in the unified and project handler managers.Changes
loadCustomSafeOutputJobTypes()function to parseGH_AW_SAFE_OUTPUT_JOBSenv var (shared helper for both handler managers)loadCustomSafeOutputJobTypes()from helper file (removed duplicate implementations)STANDALONE_STEP_TYPES)safe_output_helpers.test.cjsfor centralized testingHow It Works
GH_AW_SAFE_OUTPUT_JOBSas JSON map of job names → output keysSTANDALONE_STEP_TYPES)Example
For workflow with:
Messages with
type: "notion_add_comment"are properly recognized and skipped by handler managers.Validation
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.