Add absolute path validation for MCP gateway payloadDir field#13183
Merged
Add absolute path validation for MCP gateway payloadDir field#13183
Conversation
Contributor
🔍 PR Triage ResultsCategory: chore | Risk: medium | Priority: 35/100 Scores Breakdown
📋 Recommended Action: deferThis is a WIP draft with no code changes yet. Schema validation improvements are valuable but not urgent. Can be triaged again once implementation is complete. Triaged by PR Triage Agent on 2026-02-02
|
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
pelikhan
approved these changes
Feb 2, 2026
Copilot
AI
changed the title
[WIP] Validate payloadDir field in gateway object
Add absolute path validation for MCP gateway payloadDir field
Feb 2, 2026
Contributor
|
PR titles: Add absolute path validation for MCP gateway payloadDir field | Refactor compiler to use grouped shell redirects (fix SC2129)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
payloadDirfield in the MCP gateway configuration lacked path validation, allowing relative paths that could create security and portability issues.Changes
Specification (Section 4.1.3.1): Added RFC 2119 requirements enforcing absolute paths
/:\JSON Schema: Added pattern constraint
^(/|[A-Za-z]:\\)to both schema filespkg/workflow/schemas/mcp-gateway-config.schema.jsondocs/public/schemas/mcp-gateway-config.schema.jsonCompliance Testing: Added test T-CFG-005 for payload directory path validation
Example
Valid paths:
{ "gateway": { "payloadDir": "/var/lib/mcp-gateway/payloads" // Unix } }{ "gateway": { "payloadDir": "C:\\Program Files\\Gateway\\payloads" // Windows } }Invalid paths now rejected:
{ "gateway": { "payloadDir": "payloads" // Relative path - rejected } }💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.