Propagate create-discussion errors to conclusion job failure tracking #13399

Copilot · 2026-02-03T03:18:05Z

Summary: Propagate create-discussion Errors to Conclusion Job

Problem

When a create-discussion safe output fails, the error is not propagated to the agent failure tracking in the conclusion job, so failures are not reported in tracking issues/comments.

Reference: https://github.com/github/gh-aw/actions/runs/21615216168/job/62293027909#step:6:1

Solution

Implemented error tracking for create_discussion following the same pattern as assign_to_agent. All code review feedback addressed.

Implementation Complete ✅

Changes Made

JavaScript Changes

safe_output_handler_manager.cjs: Collect and export create_discussion errors
handle_agent_failure.cjs: Display create_discussion errors with helper function (merged with main branch checkout PR changes)
Agent failure templates: Include create_discussion_errors_context

Go Changes

compiler_safe_outputs_job.go: Add error outputs to safe_outputs job
notify_comment.go: Pass errors to conclusion job as environment variables

Tests

Comprehensive test coverage in handle_agent_failure.test.cjs
All existing tests continue to pass

This ensures create_discussion failures are properly tracked and reported in failure tracking issues/comments.

Original prompt

Reference: https://github.com/github/gh-aw/actions/runs/21615216168/job/62293027909#step:6:1

When a create-discussion safe outout fails, the error should be propagated to the agent failure in conclusion job and reported in the issue/comment generated. See workflow run.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

- Track failed create_discussion messages in safe_output_handler_manager.cjs - Export create_discussion_errors and create_discussion_error_count as outputs - Add outputs to safe_outputs job in compiler_safe_outputs_job.go - Pass errors as environment variables to conclusion job in notify_comment.go - Update handle_agent_failure.cjs to include create_discussion errors in issue/comment - Update agent failure templates to include create_discussion_errors_context placeholder Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

All tests passing. Feature is ready for review. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

…er function Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan · 2026-02-03T05:04:06Z

@copilot merge main and recompile

Copilot

Pull request overview

Propagates create_discussion safe-output failures from the safe_outputs job into the conclusion job so they can be reported in failure tracking issues/comments.

Changes:

Export create_discussion_errors and create_discussion_error_count from safe_output_handler_manager.cjs.
Wire new outputs through the Go workflow compiler into the conclusion job env vars.
Render create-discussion failure details in handle_agent_failure.cjs and corresponding templates/tests.

Reviewed changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
pkg/workflow/notify_comment.go	Passes create-discussion error outputs to the conclusion job via env vars when create-discussions is configured.
pkg/workflow/compiler_safe_outputs_job.go	Adds `create_discussion_errors` and `create_discussion_error_count` to `safe_outputs` job outputs.
actions/setup/md/agent_failure_issue.md	Adds `{create_discussion_errors_context}` placeholder to failure issue template.
actions/setup/md/agent_failure_comment.md	Adds `{create_discussion_errors_context}` placeholder to failure comment template.
actions/setup/js/safe_output_handler_manager.cjs	Collects failed `create_discussion` results and exports them as step outputs.
actions/setup/js/handle_agent_failure.cjs	Builds and injects a “Create Discussion Failed” section into failure issue/comment bodies.
actions/setup/js/handle_agent_failure.test.cjs	Adds a test asserting create-discussion errors appear in the created failure issue body.
.github/workflows/cli-consistency-checker.lock.yml	Exposes new safe_outputs job outputs for create-discussion errors.
.github/workflows/claude-code-user-docs-review.lock.yml	Exposes new safe_outputs outputs and passes them into the failure handler env.
.github/workflows/ci-doctor.lock.yml	Exposes new safe_outputs job outputs for create-discussion errors.
.github/workflows/ci-coach.lock.yml	Exposes new safe_outputs job outputs for create-discussion errors.
.github/workflows/changeset.lock.yml	Exposes new safe_outputs job outputs for create-discussion errors.
.github/workflows/breaking-change-checker.lock.yml	Exposes new safe_outputs job outputs for create-discussion errors.
.github/workflows/brave.lock.yml	Exposes new safe_outputs job outputs for create-discussion errors.
.github/workflows/blog-auditor.lock.yml	Exposes new safe_outputs outputs and passes them into the failure handler env.
.github/workflows/auto-triage-issues.lock.yml	Exposes new safe_outputs outputs and passes them into the failure handler env.
.github/workflows/audit-workflows.lock.yml	Exposes new safe_outputs outputs and passes them into the failure handler env.
.github/workflows/artifacts-summary.lock.yml	Exposes new safe_outputs outputs and passes them into the failure handler env.
.github/workflows/archie.lock.yml	Exposes new safe_outputs job outputs for create-discussion errors.
.github/workflows/ai-moderator.lock.yml	Exposes new safe_outputs job outputs for create-discussion errors.
.github/workflows/agent-persona-explorer.lock.yml	Exposes new safe_outputs outputs and passes them into the failure handler env.
.github/workflows/agent-performance-analyzer.lock.yml	Exposes new safe_outputs outputs and passes them into the failure handler env.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

actions/setup/js/safe_output_handler_manager.cjs

actions/setup/js/handle_agent_failure.cjs

Copilot · 2026-02-03T05:07:37Z

actions/setup/js/handle_agent_failure.cjs

+    const parts = errorLine.split(":");
+    if (parts.length >= 4) {
+      // parts[0] is "discussion", parts[1] is index - both unused
+      const repo = parts[2];
+      const title = parts[3];
+      const error = parts.slice(4).join(":"); // Rest is the error message
+      context += `- Discussion "${title}" in ${repo}: ${error}\n`;
+    }


buildCreateDiscussionErrorsContext() checks parts.length >= 4, but then reads parts[3] and uses parts.slice(4) for the error message. For malformed/short lines this will render an empty error; consider requiring parts.length >= 5 (or adding an explicit fallback) to avoid emitting incomplete/broken list items.

actions/setup/js/handle_agent_failure.test.cjs

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-02-03T05:10:23Z

@copilot merge main and recompile

Merged main and recompiled workflows. Commit: e376237

Initial plan

e7eaf64

Copilot AI assigned Copilot and pelikhan Feb 3, 2026

Copilot started work on behalf of pelikhan February 3, 2026 03:18 View session

This was referenced Feb 3, 2026

Skip agent failure issues when PR checkout fails #13397

Merged

Smoke Test: Copilot - 21615547949 #13400

Closed

Copilot AI and others added 5 commits February 3, 2026 03:27

Add test for create_discussion error handling in agent failure tracking

97f1444

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Complete implementation of create-discussion error propagation

a6ae877

All tests passing. Feature is ready for review. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Fix code review feedback: remove unused variables in error parsing

dcd7a66

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Refactor: extract duplicate create_discussion error parsing into help…

3237f6a

…er function Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix error propagation for create-discussion failures~~ Propagate create-discussion errors to conclusion job failure tracking Feb 3, 2026

Copilot AI requested a review from pelikhan February 3, 2026 03:36

Copilot finished work on behalf of pelikhan February 3, 2026 03:36

pelikhan approved these changes Feb 3, 2026

View reviewed changes

pelikhan marked this pull request as ready for review February 3, 2026 05:03

Copilot AI review requested due to automatic review settings February 3, 2026 05:03

Copilot started reviewing on behalf of pelikhan February 3, 2026 05:04 View session

Copilot started work on behalf of pelikhan February 3, 2026 05:04 View session

Copilot AI reviewed Feb 3, 2026

View reviewed changes

Copilot AI and others added 2 commits February 3, 2026 05:09

Merge main branch

b6a79e1

Merge main and recompile workflows

e376237

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI requested a review from pelikhan February 3, 2026 05:11

Copilot finished work on behalf of pelikhan February 3, 2026 05:11

pelikhan merged commit b2f8b8a into main Feb 3, 2026

pelikhan deleted the copilot/fix-discussion-output-error branch February 3, 2026 05:30

Claude AI mentioned this pull request Feb 3, 2026

Document root cause of daily-regulatory discussion creation failure #13421

Closed

github-actions bot mentioned this pull request Feb 3, 2026

[team-status] 🌟 Daily Team Status - February 3, 2026 #13442

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Propagate create-discussion errors to conclusion job failure tracking #13399

Propagate create-discussion errors to conclusion job failure tracking #13399

Uh oh!

Copilot AI commented Feb 3, 2026 •

edited

Loading

Uh oh!

pelikhan commented Feb 3, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 3, 2026

Uh oh!

Uh oh!

Copilot AI commented Feb 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Propagate create-discussion errors to conclusion job failure tracking #13399

Propagate create-discussion errors to conclusion job failure tracking #13399

Uh oh!

Conversation

Copilot AI commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary: Propagate create-discussion Errors to Conclusion Job

Problem

Solution

Implementation Complete ✅

Changes Made

JavaScript Changes

Go Changes

Tests

Uh oh!

pelikhan commented Feb 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI commented Feb 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Feb 3, 2026 •

edited

Loading