Skip to content

[jsweep] Clean create_issue.cjs #13428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Feb 3, 2026
+432 −50
Merged

[jsweep] Clean create_issue.cjs #13428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1637a8
feat: clean and test create_issue.cjs
Feb 3, 2026
d59e2ef
Initial plan (#13456)
Copilot Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
89 changes: 39 additions & 50 deletions actions/setup/js/create_issue.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,11 +188,11 @@ function createParentIssueTemplate(groupId, titlePrefix, workflowName, workflowS
*/
async function main(config = {}) {
// Extract configuration
const envLabels = config.labels ? (Array.isArray(config.labels) ? config.labels : config.labels.split(",")).map(label => String(label).trim()).filter(label => label) : [];
const envAssignees = config.assignees ? (Array.isArray(config.assignees) ? config.assignees : config.assignees.split(",")).map(assignee => String(assignee).trim()).filter(assignee => assignee) : [];
const titlePrefix = config.title_prefix || "";
const envLabels = config.labels ? (Array.isArray(config.labels) ? config.labels : config.labels.split(",")).map(label => String(label).trim()).filter(Boolean) : [];
const envAssignees = config.assignees ? (Array.isArray(config.assignees) ? config.assignees : config.assignees.split(",")).map(assignee => String(assignee).trim()).filter(Boolean) : [];
const titlePrefix = config.title_prefix ?? "";
const expiresHours = config.expires ? parseInt(String(config.expires), 10) : 0;
const maxCount = config.max || 10;
const maxCount = config.max ?? 10;
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using nullish coalescing operator (??) instead of logical OR (||) changes the behavior when config.max is 0. With the old code (||), if config.max was 0 (a falsy value), it would default to 10. With the new code (??), if config.max is 0, it will use 0, which would prevent any issues from being created since the check is processedCount >= maxCount (0 >= 0 = true immediately). If 0 is intended to mean "use default" rather than "create no issues", this is a breaking change. Consider whether config.max = 0 should behave as "no limit" or "create no issues", and if the former, revert to using || operator.

Suggested change
const maxCount = config.max ?? 10;
const maxCount = config.max || 10;

Copilot uses AI. Check for mistakes.
const allowedRepos = parseAllowedRepos(config.allowed_repos);
const defaultTargetRepo = getDefaultTargetRepo(config);
const groupEnabled = config.group === true || config.group === "true";
Expand Down Expand Up @@ -261,8 +261,6 @@ async function main(config = {}) {

processedCount++;

const createIssueItem = message;

// Merge external resolved temp IDs with our local map
if (resolvedTemporaryIds) {
for (const [tempId, resolved] of Object.entries(resolvedTemporaryIds)) {
Expand All @@ -273,7 +271,7 @@ async function main(config = {}) {
}

// Determine target repository for this issue
const itemRepo = createIssueItem.repo ? String(createIssueItem.repo).trim() : defaultTargetRepo;
const itemRepo = message.repo ? String(message.repo).trim() : defaultTargetRepo;

// Validate the repository is allowed
const repoValidation = validateRepo(itemRepo, defaultTargetRepo, allowedRepos);
Expand Down Expand Up @@ -305,39 +303,38 @@ async function main(config = {}) {
}

// Get or generate the temporary ID for this issue
const temporaryId = createIssueItem.temporary_id || generateTemporaryId();
core.info(`Processing create_issue: title=${createIssueItem.title}, bodyLength=${createIssueItem.body?.length || 0}, temporaryId=${temporaryId}, repo=${qualifiedItemRepo}`);
const temporaryId = message.temporary_id ?? generateTemporaryId();
core.info(`Processing create_issue: title=${message.title}, bodyLength=${message.body?.length ?? 0}, temporaryId=${temporaryId}, repo=${qualifiedItemRepo}`);

// Resolve parent: check if it's a temporary ID reference
let effectiveParentIssueNumber;
let effectiveParentRepo = qualifiedItemRepo; // Default to same repo
if (createIssueItem.parent !== undefined) {
if (message.parent !== undefined) {
// Strip # prefix if present to allow flexible temporary ID format
const parentStr = String(createIssueItem.parent).trim();
const parentStr = String(message.parent).trim();
const parentWithoutHash = parentStr.startsWith("#") ? parentStr.substring(1) : parentStr;

if (isTemporaryId(parentWithoutHash)) {
// It's a temporary ID, look it up in the map
const resolvedParent = temporaryIdMap.get(normalizeTemporaryId(parentWithoutHash));
if (resolvedParent !== undefined) {
if (resolvedParent) {
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change from checking resolvedParent !== undefined to using a truthy check (if (resolvedParent)) is semantically different. While it works correctly in this specific case (since resolvedParent is an object when present and undefined when absent), it's less precise. The !== undefined check is more explicit and defensive, making the code more resilient to future changes where resolvedParent might have falsy but valid values. Consider reverting to the original !== undefined check for clarity and robustness.

Suggested change
if (resolvedParent) {
if (resolvedParent !== undefined) {

Copilot uses AI. Check for mistakes.
effectiveParentIssueNumber = resolvedParent.number;
effectiveParentRepo = resolvedParent.repo;
core.info(`Resolved parent temporary ID '${createIssueItem.parent}' to ${effectiveParentRepo}#${effectiveParentIssueNumber}`);
core.info(`Resolved parent temporary ID '${message.parent}' to ${effectiveParentRepo}#${effectiveParentIssueNumber}`);
} else {
core.warning(`Parent temporary ID '${createIssueItem.parent}' not found in map. Ensure parent issue is created before sub-issues.`);
effectiveParentIssueNumber = undefined;
core.warning(`Parent temporary ID '${message.parent}' not found in map. Ensure parent issue is created before sub-issues.`);
}
} else {
// Check if it looks like a malformed temporary ID
if (parentWithoutHash.startsWith("aw_")) {
core.warning(`Invalid temporary ID format for parent: '${createIssueItem.parent}'. Temporary IDs must be in format 'aw_' followed by exactly 12 hexadecimal characters (0-9, a-f). Example: 'aw_abc123def456'`);
effectiveParentIssueNumber = undefined;
core.warning(`Invalid temporary ID format for parent: '${message.parent}'. Temporary IDs must be in format 'aw_' followed by exactly 12 hexadecimal characters (0-9, a-f). Example: 'aw_abc123def456'`);
} else {
// It's a real issue number
effectiveParentIssueNumber = parseInt(parentWithoutHash, 10);
if (isNaN(effectiveParentIssueNumber)) {
core.warning(`Invalid parent value: ${createIssueItem.parent}. Expected either a valid temporary ID (format: aw_XXXXXXXXXXXX where X is a hex digit) or a numeric issue number.`);
effectiveParentIssueNumber = undefined;
const parsed = parseInt(parentWithoutHash, 10);
if (!isNaN(parsed)) {
effectiveParentIssueNumber = parsed;
} else {
core.warning(`Invalid parent value: ${message.parent}. Expected either a valid temporary ID (format: aw_XXXXXXXXXXXX where X is a hex digit) or a numeric issue number.`);
}
}
}
Expand All @@ -350,28 +347,20 @@ async function main(config = {}) {
}

// Build labels array
let labels = [...envLabels];
if (createIssueItem.labels && Array.isArray(createIssueItem.labels)) {
labels = [...labels, ...createIssueItem.labels];
}
labels = labels
.filter(label => !!label)
const labels = [...envLabels, ...(Array.isArray(message.labels) ? message.labels : [])]
.filter(Boolean)
.map(label => String(label).trim())
.filter(label => label)
.filter(Boolean)
.map(label => sanitizeLabelContent(label))
.filter(label => label)
.filter(Boolean)
.map(label => (label.length > 64 ? label.substring(0, 64) : label))
.filter((label, index, arr) => arr.indexOf(label) === index);

// Build assignees array (merge config default assignees with message-specific assignees)
let assignees = [...envAssignees];
if (createIssueItem.assignees && Array.isArray(createIssueItem.assignees)) {
assignees = [...assignees, ...createIssueItem.assignees];
}
assignees = assignees
.filter(assignee => !!assignee)
let assignees = [...envAssignees, ...(Array.isArray(message.assignees) ? message.assignees : [])]
.filter(Boolean)
.map(assignee => String(assignee).trim())
.filter(assignee => assignee)
.filter(Boolean)
.filter((assignee, index, arr) => arr.indexOf(assignee) === index);

// Check if copilot is in the assignees list
Expand All @@ -381,18 +370,18 @@ async function main(config = {}) {
// Copilot is not a valid GitHub user and must be assigned via the agent assignment API
assignees = assignees.filter(assignee => assignee !== "copilot");

let title = createIssueItem.title ? createIssueItem.title.trim() : "";
let title = message.title?.trim() ?? "";

// Replace temporary ID references in the body using already-created issues
let processedBody = replaceTemporaryIdReferences(createIssueItem.body || "", temporaryIdMap, qualifiedItemRepo);
let processedBody = replaceTemporaryIdReferences(message.body ?? "", temporaryIdMap, qualifiedItemRepo);

// Remove duplicate title from description if it starts with a header matching the title
processedBody = removeDuplicateTitleFromDescription(title, processedBody);

let bodyLines = processedBody.split("\n");
const bodyLines = processedBody.split("\n");

if (!title) {
title = createIssueItem.body || "Agent Output";
title = message.body ?? "Agent Output";
}

// Apply title prefix
Expand All @@ -411,12 +400,12 @@ async function main(config = {}) {
}
}

const workflowName = process.env.GH_AW_WORKFLOW_NAME || "Workflow";
const workflowSource = process.env.GH_AW_WORKFLOW_SOURCE || "";
const workflowSourceURL = process.env.GH_AW_WORKFLOW_SOURCE_URL || "";
const workflowId = process.env.GH_AW_WORKFLOW_ID || "";
const runId = context.runId;
const githubServer = process.env.GITHUB_SERVER_URL || "https://github.com";
const workflowName = process.env.GH_AW_WORKFLOW_NAME ?? "Workflow";
const workflowSource = process.env.GH_AW_WORKFLOW_SOURCE ?? "";
const workflowSourceURL = process.env.GH_AW_WORKFLOW_SOURCE_URL ?? "";
const workflowId = process.env.GH_AW_WORKFLOW_ID ?? "";
const { runId } = context;
const githubServer = process.env.GITHUB_SERVER_URL ?? "https://github.com";
const runUrl = context.payload.repository ? `${context.payload.repository.html_url}/actions/runs/${runId}` : `${githubServer}/${context.repo.owner}/${context.repo.repo}/actions/runs/${runId}`;

// Add tracker-id comment if present
Expand Down Expand Up @@ -449,10 +438,10 @@ async function main(config = {}) {
const { data: issue } = await github.rest.issues.create({
owner: repoParts.owner,
repo: repoParts.repo,
title: title,
body: body,
labels: labels,
assignees: assignees,
title,
body,
labels,
assignees,
});

core.info(`Created issue ${qualifiedItemRepo}#${issue.number}: ${issue.html_url}`);
Expand Down
Loading
Loading