Fix flaky dispatch_workflow test timing assertion#13457
Merged
pelikhan merged 2 commits intocodex/refactor-expired-entity-scriptsfrom Feb 3, 2026
Merged
Fix flaky dispatch_workflow test timing assertion#13457pelikhan merged 2 commits intocodex/refactor-expired-entity-scriptsfrom
pelikhan merged 2 commits intocodex/refactor-expired-entity-scriptsfrom
Conversation
…tter The test was failing with 4999ms when expecting >= 5000ms due to timing overhead between when the test measures time and when the dispatch delay is calculated. Changed threshold to 4995ms to account for sub-millisecond timing jitter while still validating the 5-second delay behavior. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing tests in the codebase
Fix flaky dispatch_workflow test timing assertion
Feb 3, 2026
pelikhan
approved these changes
Feb 3, 2026
7f74974
into
codex/refactor-expired-entity-scripts
1 check passed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a flaky test in dispatch_workflow.test.cjs that was failing in CI due to JavaScript execution timing overhead when measuring delays.
Changes:
- Relaxed the timing assertion threshold from 5000ms to 4995ms (0.1% tolerance) to account for sub-millisecond jitter between
Date.now()calls - Updated the comment to clarify that the test verifies "approximately 5 seconds" delay and explain the tolerance
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
dispatch_workflow.test.cjstest was intermittently failing in CI due to strict timing expectations that didn't account for JavaScript execution overhead.Changes
>= 5000msto>= 4995msin the dispatch delay testOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.