Skip to content

chore: remove campaign-specific references#13571

Merged
mnkiefer merged 8 commits intomainfrom
campaign-cleaning
Feb 3, 2026
Merged

chore: remove campaign-specific references#13571
mnkiefer merged 8 commits intomainfrom
campaign-cleaning

Conversation

@mnkiefer
Copy link
Contributor

@mnkiefer mnkiefer commented Feb 3, 2026

  • Removes campaign-specific conventions and validation logic from the repo-memory workflow and codebase, generalizing previous campaign-focused features to support broader use cases.
  • Updates terminology and configuration to reflect this shift, and cleans up related code.

@mnkiefer mnkiefer self-assigned this Feb 3, 2026
Copilot AI review requested due to automatic review settings February 3, 2026 19:43
@mnkiefer
Copy link
Contributor Author

mnkiefer commented Feb 3, 2026

@copilot fix lint errors

Copy link
Contributor

Copilot AI commented Feb 3, 2026

@mnkiefer I've opened a new pull request, #13572, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes campaign-specific terminology and functionality from the codebase, generalizing features that were previously focused on campaign workflows to support broader use cases.

Changes:

  • Removes campaign_id field from schemas, validation configs, and safe output handlers across Go and JavaScript code
  • Updates terminology from campaign-specific terms (e.g., "Campaign Id", "campaign setup") to more general terms (e.g., "Tracker Id", "project setup")
  • Removes campaign-specific validation logic, labels, constants, and helper functions from repo-memory workflow and related components

Reviewed changes

Copilot reviewed 37 out of 37 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
schemas/agent-output.json Removed campaign_id field from schema
pkg/workflow/update_project_handler_config_test.go Updated test to use tracker_id instead of campaign_id
pkg/workflow/safe_outputs_test.go Removed campaign-related test expectations
pkg/workflow/safe_outputs_env.go Removed getCampaignIDFromRepoMemory function and related env var logic
pkg/workflow/safe_output_validation_config.go Removed campaign_id field validation from update_project config
pkg/workflow/repo_memory_test.go Removed campaign-specific test and updated terminology
pkg/workflow/repo_memory.go Removed CampaignID field and parsing logic
pkg/workflow/js/safe_outputs_tools.json Updated descriptions removing campaign references
pkg/workflow/frontmatter_types.go Removed campaign-related type definitions (ProjectConfig, CampaignGovernanceConfig, etc.)
pkg/workflow/create_project_test.go Updated test data from "Campaign" terminology to "Project"
pkg/workflow/compiler_jobs_test.go Renamed test and updated from campaign-specific to generic workflow terminology
pkg/stringutil/identifiers.go Removed FormatCampaignLabel function and imports
pkg/parser/schemas/main_workflow_schema.json Updated descriptions removing campaign references
pkg/constants/constants.go Removed campaign-related constants
pkg/cli/project_command_test.go Updated flag tests from with-campaign-setup to with-project-setup
pkg/cli/project_command.go Renamed flag and config from campaign to project terminology
pkg/cli/logs_orchestrator.go Removed campaign filtering logic
pkg/cli/logs_json_stderr_order_test.go Removed campaignOnly parameter from test calls
pkg/cli/logs_download_test.go Removed campaignOnly parameter from test calls
pkg/cli/logs_command.go Removed --campaign flag and parameter
pkg/cli/logs_ci_scenario_test.go Removed campaignOnly parameter from test call
pkg/cli/context_cancellation_test.go Removed campaignOnly parameter from test calls
actions/setup/js/update_project.test.cjs Removed campaign-specific tests and updated field names
actions/setup/js/update_project.cjs Removed campaign label application logic and related functions
actions/setup/js/update_issue_generator.test.cjs Updated test descriptions and data
actions/setup/js/safe_outputs_tools.json Updated tool descriptions removing campaign references
actions/setup/js/safe_output_unified_handler_manager.cjs Removed campaign label helper imports and application logic
actions/setup/js/safe_output_handler_manager.test.cjs Removed campaign label injection test
actions/setup/js/safe_output_handler_manager.cjs Removed campaign label formatting and application functions
actions/setup/js/push_repo_memory.test.cjs Updated test terminology from campaign to generic terms
actions/setup/js/push_repo_memory.cjs Removed campaign-specific validation functions and logic
actions/setup/js/glob_pattern_helpers.test.cjs Updated test descriptions
actions/setup/js/create_project.cjs Updated default title prefix from "Campaign" to "Project"
actions/setup/js/campaign_labels.test.cjs Deleted entire test file
actions/setup/js/campaign_labels.cjs Deleted entire module file
.serena/project.yml Added new configuration options (unrelated to campaign removal)
.github/aw/main_workflow_schema.json Updated description removing campaign reference

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mnkiefer
Copy link
Contributor Author

mnkiefer commented Feb 3, 2026

@copilot Fix CI / Test (pull_request) and canary

Copy link
Contributor

Copilot AI commented Feb 3, 2026

@mnkiefer I've opened a new pull request, #13573, to work on those changes. Once the pull request is ready, I'll request review from you.

@mnkiefer mnkiefer merged commit f0d8db2 into main Feb 3, 2026
53 checks passed
@mnkiefer mnkiefer deleted the campaign-cleaning branch February 3, 2026 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants