Skip to content

Fix TestSetupCLIAction integration test string expectations #13773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 4 commits into from
Feb 4, 2026
Merged

Fix TestSetupCLIAction integration test string expectations #13773

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
02f709a
Initial plan
Copilot Feb 4, 2026
d73996b
Fix TestSetupCLIAction integration test failing due to mismatched str…
Copilot Feb 4, 2026
16c3f71
Fix TestSetupCLIAction integration test to match actual script strings
Copilot Feb 4, 2026
8568250
Merge branch 'main' into copilot/fix-testsetupcli-action-errors
pelikhan Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pkg/cli/setup_cli_action_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ func TestSetupCLIAction(t *testing.T) {
t.Fatalf("Failed to read install.sh: %v", err)
}
// Verify script has fallback to fetch latest
if !strings.Contains(string(content), "No version specified") || !strings.Contains(string(content), "fetching latest") {
if !strings.Contains(string(content), "No version specified") || !strings.Contains(string(content), "using 'latest'") {
t.Errorf("Script should support fetching latest release when no version is provided")
}
})
Expand Down Expand Up @@ -84,7 +84,8 @@ func TestSetupCLIAction(t *testing.T) {
if err != nil {
t.Fatalf("Failed to read install.sh: %v", err)
}
if !strings.Contains(string(content), "Validating release") {
// Verify script has binary verification logic
if !strings.Contains(string(content), "Verifying binary") {
t.Errorf("Script does not include release validation")
}
})
Expand Down
Loading