Skip to content

Fix testifylint violations in trial_dry_run_test.go#13812

Merged
pelikhan merged 3 commits intomainfrom
copilot/fix-lint-go-workflow-again
Feb 4, 2026
Merged

Fix testifylint violations in trial_dry_run_test.go#13812
pelikhan merged 3 commits intomainfrom
copilot/fix-lint-go-workflow-again

Conversation

Copy link
Contributor

Copilot AI commented Feb 4, 2026

The lint-go workflow was failing on two testifylint violations where assert.NoError should be require.NoError for critical error checks.

Changes

  • Line 272: assert.NoErrorrequire.NoError for dry-run execution error
  • Line 336: assert.NoErrorrequire.NoError for dry-run mode error

Rationale

Testifylint enforces using require.* for error assertions that are prerequisites for subsequent test logic. Both assertions guard operations where test continuation on error would be meaningless.

// Before
assert.NoError(t, err, "Dry-run should not error")

// After  
require.NoError(t, err, "Dry-run should not error")
Original prompt

Fix the failing GitHub Actions workflow lint-go
Analyze the workflow logs, identify the root cause of the failure, and implement a fix.
Job ID: 62553613266
Job URL: https://github.com/github/gh-aw/actions/runs/21691962911/job/62553613266


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions workflow lint-go Fix testifylint violations in trial_dry_run_test.go Feb 4, 2026
Copilot AI requested a review from pelikhan February 4, 2026 23:36
@pelikhan pelikhan marked this pull request as ready for review February 4, 2026 23:42
Copilot AI review requested due to automatic review settings February 4, 2026 23:42
@pelikhan pelikhan merged commit 7773c18 into main Feb 4, 2026
51 checks passed
@pelikhan pelikhan deleted the copilot/fix-lint-go-workflow-again branch February 4, 2026 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants