Normalize file paths to Unix format in compiled .lock.yml files by Copilot · Pull Request #13853 · github/gh-aw

Copilot · 2026-02-05T05:34:24Z

The compiler generates platform-specific paths in .lock.yml files. On Windows, this produces backslash separators which breaks cross-platform workflows.

Changes

Applied filepath.ToSlash() normalization at all YAML output points:

pkg/workflow/compiler_yaml.go: Normalize Source, ImportedFiles, IncludedFiles, and runtime-import paths before writing to YAML header and prompt
pkg/parser/include_expander.go: Normalize paths when building the included files manifest

Example

Before (Windows):

# Resolved workflow manifest:
#   Imports:
#     - shared\jqschema.md
#     - shared\reporting.md

# Prompt section:
{{#runtime-import workflows\test.md}}

After (all platforms):

# Resolved workflow manifest:
#   Imports:
#     - shared/jqschema.md
#     - shared/reporting.md

# Prompt section:
{{#runtime-import workflows/test.md}}

Added test coverage in compiler_path_normalization_test.go for imports, includes, source paths, and nested directory structures.

Original prompt

Review the compiler such that it always generates unix compatible file path in the compiled .lock.yml file. This means that when the compiler is running on windows is should NOT generate path with forward /.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan · 2026-02-05T05:55:00Z

@copilot recompile

pelikhan · 2026-02-05T05:55:37Z

@copilot make sure the paths passed in runtime-import is using ToSlash.

Copilot · 2026-02-05T05:59:31Z

@copilot recompile

Recompilation completed successfully. All 145 workflows compiled with no changes to existing .lock.yml files. The path normalization is working as expected - on Unix systems, paths already use forward slashes, so no modifications were needed. On Windows, the new code will normalize backslashes to forward slashes.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-02-05T06:06:47Z

@copilot make sure the paths passed in runtime-import is using ToSlash.

Added filepath.ToSlash() normalization to the runtime-import path in compiler_yaml.go (line 303). The workflow file path is now normalized to use forward slashes before being used in the {{#runtime-import}} macro. All 145 workflows recompiled successfully. Commit: f1f9758

Copilot

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-05T06:10:31Z

pkg/workflow/compiler_path_normalization_test.go

+func TestCompilerGeneratesUnixPaths(t *testing.T) {
+	tests := []struct {
+		name                 string
+		markdownContent      string
+		expectedImportPaths  []string
+		expectedIncludePaths []string
+		expectedSourcePath   string
+	}{
+		{
+			name: "imports with forward slashes",
+			markdownContent: `---
+on: issues
+imports:
+  - shared/common.md
+  - shared/reporting.md
+source: workflows/test-workflow.md
+---
+
+# Test Workflow
+
+This is a test workflow with imports.`,
+			expectedImportPaths: []string{
+				"shared/common.md",
+				"shared/reporting.md",
+			},
+			expectedSourcePath: "workflows/test-workflow.md",
+		},
+		{
+			name: "includes with forward slashes",
+			markdownContent: `---
+on: pull_request
+---
+
+# Test Include Workflow
+
+{{#import shared/tools.md}}
+
+This workflow includes external tools.`,
+			expectedIncludePaths: []string{
+				"shared/tools.md",
+			},
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			// Create temporary directory for test
+			tmpDir := t.TempDir()
+
+			// Create shared directory and files for imports/includes
+			sharedDir := filepath.Join(tmpDir, "shared")
+			err := os.MkdirAll(sharedDir, 0755)
+			require.NoError(t, err, "Failed to create shared directory")
+
+			// Create shared/common.md (shared workflow - minimal valid content)
+			commonContent := `# Common Shared Workflow
+
+This is a shared workflow.`
+			commonFile := filepath.Join(sharedDir, "common.md")
+			err = os.WriteFile(commonFile, []byte(commonContent), 0644)
+			require.NoError(t, err, "Failed to create common.md")
+
+			// Create shared/reporting.md (shared workflow - minimal valid content)
+			reportingContent := `# Reporting Shared Workflow
+
+This is a shared workflow.`
+			reportingFile := filepath.Join(sharedDir, "reporting.md")
+			err = os.WriteFile(reportingFile, []byte(reportingContent), 0644)
+			require.NoError(t, err, "Failed to create reporting.md")
+
+			// Create shared/tools.md (shared workflow - minimal valid content)
+			toolsContent := `# Tools Shared Workflow
+
+This is a shared workflow.`
+			toolsFile := filepath.Join(sharedDir, "tools.md")
+			err = os.WriteFile(toolsFile, []byte(toolsContent), 0644)
+			require.NoError(t, err, "Failed to create tools.md")
+
+			// Create workflows directory for source path
+			workflowsDir := filepath.Join(tmpDir, "workflows")
+			err = os.MkdirAll(workflowsDir, 0755)
+			require.NoError(t, err, "Failed to create workflows directory")
+
+			// Write markdown file
+			markdownPath := filepath.Join(tmpDir, "test-workflow.md")
+			err = os.WriteFile(markdownPath, []byte(tt.markdownContent), 0644)
+			require.NoError(t, err, "Failed to write markdown file")
+
+			// Compile the workflow
+			compiler := NewCompiler()
+			err = compiler.CompileWorkflow(markdownPath)
+			require.NoError(t, err, "Compilation should succeed")
+
+			// Read the generated .lock.yml file
+			lockFile := filepath.Join(tmpDir, "test-workflow.lock.yml")
+			lockContent, err := os.ReadFile(lockFile)
+			require.NoError(t, err, "Failed to read lock file")
+
+			lockYAML := string(lockContent)
+
+			// Verify that file paths in the manifest use forward slashes (Unix-compatible)
+			// Note: The ASCII art header contains backslashes, so we only check the manifest section
+			manifestStart := strings.Index(lockYAML, "# Resolved workflow manifest:")
+			sourceStart := strings.Index(lockYAML, "# Source:")
+
+			// Verify expected import paths are present with forward slashes
+			for _, importPath := range tt.expectedImportPaths {
+				expectedLine := "#     - " + importPath
+				assert.Contains(t, lockYAML, expectedLine, "Lock file should contain import path: %s", importPath)
+
+				// Ensure no backslash version exists
+				backslashPath := strings.ReplaceAll(importPath, "/", "\\")
+				backslashLine := "#     - " + backslashPath
+				assert.NotContains(t, lockYAML, backslashLine, "Lock file should not contain backslash version of: %s", importPath)
+			}
+
+			// Verify expected include paths are present with forward slashes
+			for _, includePath := range tt.expectedIncludePaths {
+				expectedLine := "#     - " + includePath
+				assert.Contains(t, lockYAML, expectedLine, "Lock file should contain include path: %s", includePath)
+
+				// Ensure no backslash version exists
+				backslashPath := strings.ReplaceAll(includePath, "/", "\\")
+				backslashLine := "#     - " + backslashPath
+				assert.NotContains(t, lockYAML, backslashLine, "Lock file should not contain backslash version of: %s", includePath)
+			}
+
+			// Verify source path uses forward slashes
+			if tt.expectedSourcePath != "" {
+				expectedLine := "# Source: " + tt.expectedSourcePath
+				assert.Contains(t, lockYAML, expectedLine, "Lock file should contain source path: %s", tt.expectedSourcePath)
+
+				// Ensure no backslash version exists
+				backslashPath := strings.ReplaceAll(tt.expectedSourcePath, "/", "\\")
+				backslashLine := "# Source: " + backslashPath
+				assert.NotContains(t, lockYAML, backslashLine, "Lock file should not contain backslash version of source: %s", tt.expectedSourcePath)
+			}
+
+			// Verify that manifest section does not contain backslashes in file paths
+			if manifestStart >= 0 {
+				manifestEnd := strings.Index(lockYAML[manifestStart:], "\n\n")
+				if manifestEnd >= 0 {
+					manifest := lockYAML[manifestStart : manifestStart+manifestEnd]
+					assert.NotContains(t, manifest, "\\", "Lock file manifest should not contain backslashes in file paths")
+				}
+			}
+
+			// Verify that source section does not contain backslashes in file paths
+			if sourceStart >= 0 && tt.expectedSourcePath != "" {
+				sourceEnd := strings.Index(lockYAML[sourceStart:], "\n")
+				if sourceEnd >= 0 {
+					sourceLine := lockYAML[sourceStart : sourceStart+sourceEnd]
+					// Check that the source line doesn't contain a Windows path
+					backslashPath := strings.ReplaceAll(tt.expectedSourcePath, "/", "\\")
+					assert.NotContains(t, sourceLine, backslashPath, "Source line should not contain Windows-style path")
+				}
+			}
+		})
+	}
+}


The test suite doesn't verify the runtime-import path normalization. Consider adding a test case that checks the generated runtime-import macro path in the lock file contains forward slashes. For example, verify that a workflow file at workflows\test.md on Windows generates {{#runtime-import workflows/test.md}} instead of {{#runtime-import workflows\test.md}}.

Initial plan

138c9db

Copilot AI assigned Copilot and pelikhan Feb 5, 2026

Copilot started work on behalf of pelikhan February 5, 2026 05:34 View session

Copilot AI and others added 3 commits February 5, 2026 05:43

Add test for Unix path generation in .lock.yml files

9998866

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Add filepath.ToSlash() to normalize paths in YAML output

c5f7171

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Complete: Unix path normalization in .lock.yml files

186edd4

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix compiler to generate unix compatible file paths in .lock.yml~~ Normalize file paths to Unix format in compiled .lock.yml files Feb 5, 2026

Copilot AI requested a review from pelikhan February 5, 2026 05:51

Copilot finished work on behalf of pelikhan February 5, 2026 05:51

Copilot started work on behalf of pelikhan February 5, 2026 05:55 View session

Copilot finished work on behalf of pelikhan February 5, 2026 06:00

Copilot started work on behalf of pelikhan February 5, 2026 06:00 View session

Add filepath.ToSlash() to runtime-import path normalization

f1f9758

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan February 5, 2026 06:07

pelikhan marked this pull request as ready for review February 5, 2026 06:07

Copilot AI review requested due to automatic review settings February 5, 2026 06:07

Copilot started reviewing on behalf of pelikhan February 5, 2026 06:07 View session

Copilot AI reviewed Feb 5, 2026

View reviewed changes

pelikhan merged commit c6d30be into main Feb 5, 2026
131 checks passed

pelikhan deleted the copilot/fix-unix-compatible-file-paths branch February 5, 2026 06:13

This was referenced Feb 5, 2026

[docs] Update documentation for trial --dry-run flag #13874

Merged

[team-status] 🌟 Daily Team Status - February 5, 2026 #13885

Closed

Smoke Test: Copilot - 21712693967 #13904

Closed

qmuntal mentioned this pull request Feb 5, 2026

workflows compiled on Windows can't be executed on Linux #13543

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Normalize file paths to Unix format in compiled .lock.yml files#13853

Normalize file paths to Unix format in compiled .lock.yml files#13853
pelikhan merged 5 commits intomainfrom
copilot/fix-unix-compatible-file-paths

Copilot AI commented Feb 5, 2026 •

edited

Loading

Uh oh!

pelikhan commented Feb 5, 2026

Uh oh!

pelikhan commented Feb 5, 2026

Uh oh!

Copilot AI commented Feb 5, 2026

Uh oh!

Copilot AI commented Feb 5, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Copilot AI commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Example

Uh oh!

pelikhan commented Feb 5, 2026

Uh oh!

pelikhan commented Feb 5, 2026

Uh oh!

Copilot AI commented Feb 5, 2026

Uh oh!

Copilot AI commented Feb 5, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Feb 5, 2026 •

edited

Loading