Skip to content

Remove windows-386 from release build targets#13854

Merged
pelikhan merged 2 commits intomainfrom
copilot/remove-windows-386-build
Feb 5, 2026
Merged

Remove windows-386 from release build targets#13854
pelikhan merged 2 commits intomainfrom
copilot/remove-windows-386-build

Conversation

Copy link
Contributor

Copilot AI commented Feb 5, 2026

Removes 32-bit Windows (windows-386) from the list of platforms built during releases.

Changes

  • scripts/build-release.sh: Removed windows-386 from platforms array
  • scripts/test-install-script.sh: Removed corresponding platform detection test case
Original prompt

Remove windows-386 build from release.md


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove windows-386 build from release documentation Remove windows-386 from release build targets Feb 5, 2026
Copilot AI requested a review from pelikhan February 5, 2026 05:44
@pelikhan pelikhan marked this pull request as ready for review February 5, 2026 05:49
Copilot AI review requested due to automatic review settings February 5, 2026 05:49
@pelikhan pelikhan merged commit 8d5ef84 into main Feb 5, 2026
89 checks passed
@pelikhan pelikhan deleted the copilot/remove-windows-386-build branch February 5, 2026 05:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request removes 32-bit Windows (windows-386) as a supported build target for releases. The change reflects a decision to discontinue support for 32-bit Windows systems.

Changes:

  • Removed windows-386 from the platforms array in the release build script
  • Removed the corresponding platform detection test case for 32-bit Windows (MINGW32_NT-10.0 with i686)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
scripts/build-release.sh Removed windows-386 from the list of platforms to build during release
scripts/test-install-script.sh Removed test case for detecting 32-bit Windows platform (MINGW32_NT-10.0, i686)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 13 to 25
platforms=(
darwin-amd64
darwin-arm64
freebsd-386
freebsd-amd64
freebsd-arm64
linux-386
linux-amd64
linux-arm
linux-arm64
windows-386
windows-amd64
windows-arm64
)
Copy link

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of windows-386 from the build targets is incomplete. The install script (install-gh-aw.sh) still detects i386/i686 architectures and maps them to "386". If a user on 32-bit Windows (e.g., MINGW32_NT-10.0 with i686) runs the install script, it will construct a "windows-386" platform string, attempt to download a non-existent binary, and fail with a generic download error.

Consider one of these approaches:

  1. Add explicit validation in install-gh-aw.sh to reject windows-386 combination with a helpful error message explaining that 32-bit Windows is no longer supported
  2. Remove 386 architecture support entirely from the install script if it's not supported on any platform
  3. Keep 386 support only for platforms that still build it (linux-386, freebsd-386 are still in the build list)

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants