Skip to content

[jsweep] Clean add_labels.cjs #13868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 1 commit into from
Feb 5, 2026
+11 −24
Merged

[jsweep] Clean add_labels.cjs #13868

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 11 additions & 24 deletions actions/setup/js/add_labels.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,34 +48,24 @@ async function main(config = {}) {
processedCount++;

// Determine target issue/PR number
const itemNumber = message.item_number !== undefined ? parseInt(String(message.item_number), 10) : context.payload?.issue?.number || context.payload?.pull_request?.number;
const itemNumber = message.item_number !== undefined ? parseInt(String(message.item_number), 10) : (context.payload?.issue?.number ?? context.payload?.pull_request?.number);

if (!itemNumber || isNaN(itemNumber)) {
const errorMsg = message.item_number !== undefined ? `Invalid item number: ${message.item_number}` : "No item_number provided and not in issue/PR context";
core.warning(errorMsg);
return {
success: false,
error: message.item_number !== undefined ? `Invalid item number: ${message.item_number}` : "No issue/PR number available",
};
const error = message.item_number !== undefined ? `Invalid item number: ${message.item_number}` : "No issue/PR number available";
core.warning(error);
return { success: false, error };
}

const contextType = context.payload?.pull_request ? "pull request" : "issue";
const requestedLabels = message.labels ?? [];
core.info(`Requested labels: ${JSON.stringify(requestedLabels)}`);

// If no labels provided, return a helpful message with allowed labels if configured
if (!requestedLabels || requestedLabels.length === 0) {
let errorMessage = "No labels provided. Please provide at least one label from";
if (allowedLabels.length > 0) {
errorMessage += ` the allowed list: ${JSON.stringify(allowedLabels)}`;
} else {
errorMessage += " the repository's available labels";
}
core.info(errorMessage);
return {
success: false,
error: errorMessage,
};
if (requestedLabels.length === 0) {
const labelSource = allowedLabels.length > 0 ? `the allowed list: ${JSON.stringify(allowedLabels)}` : "the repository's available labels";
const error = `No labels provided. Please provide at least one label from ${labelSource}`;
core.info(error);
return { success: false, error };
}

// Use validation helper to sanitize and validate labels
Expand All @@ -101,6 +91,7 @@ async function main(config = {}) {

const uniqueLabels = labelsResult.value ?? [];

// Early return if no labels after validation
if (uniqueLabels.length === 0) {
core.info("No labels to add");
return {
Expand All @@ -121,7 +112,6 @@ async function main(config = {}) {
});

core.info(`Successfully added ${uniqueLabels.length} labels to ${contextType} #${itemNumber}`);

return {
success: true,
number: itemNumber,
Expand All @@ -131,10 +121,7 @@ async function main(config = {}) {
} catch (error) {
const errorMessage = getErrorMessage(error);
core.error(`Failed to add labels: ${errorMessage}`);
return {
success: false,
error: errorMessage,
};
return { success: false, error: errorMessage };
}
};
}
Expand Down
Loading