Skip to content

Remove tests asserting specific version constant values#13932

Merged
pelikhan merged 5 commits intomainfrom
copilot/remove-version-number-test
Feb 5, 2026
Merged

Remove tests asserting specific version constant values#13932
pelikhan merged 5 commits intomainfrom
copilot/remove-version-number-test

Conversation

Copy link
Contributor

Copilot AI commented Feb 5, 2026

Tests that assert hardcoded version numbers fail on every version bump, causing unnecessary CI failures.

Changes

  • Removed TestVersionConstants (pkg/constants/constants_test.go) - Asserted 18+ version constants matched specific values
  • Removed TestCopilotInstallerVersionPassthrough (pkg/workflow/copilot_installer_test.go) - Validated constant passthrough but tied to specific version

Rationale

Version constants change frequently:

// These fail CI every time versions are bumped
{"DefaultCopilotVersion", DefaultCopilotVersion, "0.0.402"},  // Now 0.0.403
{"DefaultCodexVersion", DefaultCodexVersion, "0.94.0"},       // Now 0.97.0
{"DefaultMCPGatewayVersion", DefaultMCPGatewayVersion, "v0.0.98"}, // Now v0.0.99

Remaining tests (TestGenerateCopilotInstallerSteps, TestCopilotInstallerCustomVersion) validate installer logic without version assertions.

Original prompt

Remove the test that checks constant version numbers.

Analyze the workflow logs, identify the root cause of the failure, and implement a fix.
Job ID: 62626808360
Job URL: https://github.com/github/gh-aw/actions/runs/21714590121/job/62626808360


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits February 5, 2026 14:55
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI and others added 2 commits February 5, 2026 14:58
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove test for constant version numbers Remove tests asserting specific version constant values Feb 5, 2026
Copilot AI requested a review from pelikhan February 5, 2026 15:07
@pelikhan pelikhan marked this pull request as ready for review February 5, 2026 15:14
Copilot AI review requested due to automatic review settings February 5, 2026 15:14
@pelikhan pelikhan merged commit e0a25da into main Feb 5, 2026
3 checks passed
@pelikhan pelikhan deleted the copilot/remove-version-number-test branch February 5, 2026 15:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes tests that assert specific hardcoded version numbers to prevent unnecessary CI failures during version bumps. The changes include removing two test functions that validated exact version values, updating workflow lock files with new version numbers, and enhancing documentation for discussion-related configuration.

Changes:

  • Removed TestVersionConstants and TestCopilotInstallerVersionPassthrough tests that asserted exact version strings
  • Updated version numbers across all workflow lock files (Copilot CLI 0.0.402→0.0.403, MCP Gateway v0.0.98→v0.0.99, Codex 0.94.0→0.97.0)
  • Enhanced documentation for close-older-discussions feature with clearer matching logic

Reviewed changes

Copilot reviewed 90 out of 90 changed files in this pull request and generated no comments.

File Description
pkg/constants/constants_test.go Removed TestVersionConstants that asserted 18+ specific version values
pkg/workflow/copilot_installer_test.go Removed TestCopilotInstallerVersionPassthrough that validated version passthrough
docs/src/content/docs/reference/frontmatter-full.md Improved documentation for discussion label matching and close-older-discussions behavior
.github/workflows/*.lock.yml (50+ files) Updated version references consistently across all workflow lock files

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants