Remove tests asserting specific version constant values#13932
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
This was referenced Feb 5, 2026
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove test for constant version numbers
Remove tests asserting specific version constant values
Feb 5, 2026
pelikhan
approved these changes
Feb 5, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes tests that assert specific hardcoded version numbers to prevent unnecessary CI failures during version bumps. The changes include removing two test functions that validated exact version values, updating workflow lock files with new version numbers, and enhancing documentation for discussion-related configuration.
Changes:
- Removed
TestVersionConstantsandTestCopilotInstallerVersionPassthroughtests that asserted exact version strings - Updated version numbers across all workflow lock files (Copilot CLI 0.0.402→0.0.403, MCP Gateway v0.0.98→v0.0.99, Codex 0.94.0→0.97.0)
- Enhanced documentation for
close-older-discussionsfeature with clearer matching logic
Reviewed changes
Copilot reviewed 90 out of 90 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/constants/constants_test.go | Removed TestVersionConstants that asserted 18+ specific version values |
| pkg/workflow/copilot_installer_test.go | Removed TestCopilotInstallerVersionPassthrough that validated version passthrough |
| docs/src/content/docs/reference/frontmatter-full.md | Improved documentation for discussion label matching and close-older-discussions behavior |
| .github/workflows/*.lock.yml (50+ files) | Updated version references consistently across all workflow lock files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests that assert hardcoded version numbers fail on every version bump, causing unnecessary CI failures.
Changes
TestVersionConstants(pkg/constants/constants_test.go) - Asserted 18+ version constants matched specific valuesTestCopilotInstallerVersionPassthrough(pkg/workflow/copilot_installer_test.go) - Validated constant passthrough but tied to specific versionRationale
Version constants change frequently:
Remaining tests (
TestGenerateCopilotInstallerSteps,TestCopilotInstallerCustomVersion) validate installer logic without version assertions.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.