fix: Remove duplicate Go module cache causing tar conflicts

[Copilot]

Fix GitHub Actions Workflow Cache Failure

Root Cause Analysis:

• The "Integration: Workflow Cache" job fails because of duplicate cache restoration
• Both actions/setup-go@v6 (with cache: true) AND a separate actions/cache@v4 action restore to the same paths (~/go/pkg/mod)
• This causes tar errors: "Cannot open: File exists" when the second cache tries to extract files that were already restored by setup-go

Fix Implemented:

• Analyze the current cache configuration in ci.yml
• Remove the redundant explicit cache action (was at lines 273-282 and 9 other locations)
• Keep setup-go's built-in caching (it's more efficient and officially recommended)
• Remove all 10 occurrences of duplicate "Cache Go modules (explicit fallback)" blocks across the CI workflow
• Validate no other workflows have the same issue (checked ci-coach.lock.yml and go-logger.lock.yml - they cache different paths so no conflict)
• Store memory about this pattern to prevent future issues
• Fix missing containsRuntimeImports function causing test compilation failure
• Format code with gofmt
• Move helper function to test file to resolve linter warnings

Technical Details:

• setup-go@v6 with cache: true automatically caches ~/go/pkg/mod and ~/.cache/go-build
• Adding an explicit actions/cache for the same paths causes a conflict
• The fix removes redundancy and follows GitHub's recommended approach

Additional Fix:

• Implemented missing containsRuntimeImports() function for integration tests
• This function was referenced in tests but never implemented, causing build failures
• Function detects runtime-import macros with local paths (./, ../) but excludes URLs
• Moved function to test file to avoid unused function linter warnings

Verification:

• All 10 redundant cache blocks removed from ci.yml
• No other workflows have conflicting cache configurations
• YAML syntax validated successfully
• All unit and integration tests pass
• Code formatted with gofmt
• All linter checks pass

Original prompt

Fix the failing GitHub Actions workflow Integration: Workflow Cache
Analyze the workflow logs, identify the root cause of the failure, and implement a fix.
Job ID: 62635814796
Job URL: https://github.com/github/gh-aw/actions/runs/21717037706/job/62635814796

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[Copilot]

Pull request overview

This PR fixes a CI workflow failure caused by duplicate Go module cache restoration. The workflow was attempting to restore the same cache paths twice - once through setup-go@v6's built-in caching and again through explicit actions/cache@v4 steps, resulting in tar extraction conflicts.

Changes:

• Removed 11 redundant "Cache Go modules (explicit fallback)" blocks that were duplicating the caching already provided by setup-go@v6
• Retained setup-go@v6 with cache: true as the single source of Go module caching

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[pelikhan]

@copilot fix tests See https://github.com/github/gh-aw/actions/runs/21718275602/job/62640375187?pr=13942

[Copilot]

@copilot fix tests See https://github.com/github/gh-aw/actions/runs/21718275602/job/62640375187?pr=13942

Fixed in 4218fbf. The test was referencing containsRuntimeImports() function that was never implemented. Added the missing function to runtime_detection.go - it detects runtime-import macros with local file paths while excluding URLs. All tests now pass.