Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/agent-performance-analyzer.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/agent-persona-explorer.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/audit-workflows.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/cloclo.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/daily-firewall-report.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions .github/workflows/daily-observability-report.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/daily-safe-output-optimizer.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions .github/workflows/deep-report.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/dev-hawk.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/example-workflow-analyzer.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/mcp-inspector.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/metrics-collector.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/portfolio-analyst.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/prompt-clustering-analysis.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/python-data-charts.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/q.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/safe-output-health.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/security-review.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/smoke-claude.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/smoke-copilot.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/static-analysis-report.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/workflow-normalizer.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions pkg/workflow/claude_mcp.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,16 @@ func (e *ClaudeEngine) RenderMCPConfig(yaml *strings.Builder, tools map[string]a
// Create unified renderer with Claude-specific options
// Claude uses JSON format without Copilot-specific fields and multi-line args
createRenderer := func(isLast bool) *MCPConfigRendererUnified {
actionMode := ActionModeDev // Default to dev mode
if workflowData != nil {
actionMode = workflowData.ActionMode
}
return NewMCPConfigRenderer(MCPRendererOptions{
IncludeCopilotFields: false, // Claude doesn't use "type" and "tools" fields
InlineArgs: false, // Claude uses multi-line args format
Format: "json",
IsLast: isLast,
ActionMode: actionMode,
})
}

Expand Down
10 changes: 10 additions & 0 deletions pkg/workflow/codex_mcp.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,16 @@ func (e *CodexEngine) RenderMCPConfig(yaml *strings.Builder, tools map[string]an
// Create unified renderer with Codex-specific options
// Codex uses TOML format without Copilot-specific fields and multi-line args
createRenderer := func(isLast bool) *MCPConfigRendererUnified {
actionMode := ActionModeDev // Default to dev mode
if workflowData != nil {
actionMode = workflowData.ActionMode
}
return NewMCPConfigRenderer(MCPRendererOptions{
IncludeCopilotFields: false, // Codex doesn't use "type" and "tools" fields
InlineArgs: false, // Codex uses multi-line args format
Format: "toml",
IsLast: isLast,
ActionMode: actionMode,
})
}

Expand Down Expand Up @@ -104,11 +109,16 @@ func (e *CodexEngine) RenderMCPConfig(yaml *strings.Builder, tools map[string]an

// Use shared JSON renderer for gateway input
createJSONRenderer := func(isLast bool) *MCPConfigRendererUnified {
actionMode := ActionModeDev // Default to dev mode
if workflowData != nil {
actionMode = workflowData.ActionMode
}
return NewMCPConfigRenderer(MCPRendererOptions{
IncludeCopilotFields: false, // Gateway doesn't need Copilot fields
InlineArgs: false, // Use standard multi-line format
Format: "json",
IsLast: isLast,
ActionMode: actionMode,
})
}

Expand Down
1 change: 1 addition & 0 deletions pkg/workflow/compiler_orchestrator_workflow.go
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ func (c *Compiler) buildInitialWorkflowData(
StrictMode: c.strictMode,
SecretMasking: toolsResult.secretMasking,
ParsedFrontmatter: toolsResult.parsedFrontmatter,
ActionMode: c.actionMode,
}
}

Expand Down
1 change: 1 addition & 0 deletions pkg/workflow/compiler_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -427,6 +427,7 @@ type WorkflowData struct {
SecretMasking *SecretMaskingConfig // secret masking configuration
ParsedFrontmatter *FrontmatterConfig // cached parsed frontmatter configuration (for performance optimization)
ActionPinWarnings map[string]bool // cache of already-warned action pin failures (key: "repo@version")
ActionMode ActionMode // action mode for workflow compilation (dev, release, script)
}

// BaseSafeOutputConfig holds common configuration fields for all safe output types
Expand Down
5 changes: 5 additions & 0 deletions pkg/workflow/copilot_mcp.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,16 @@ func (e *CopilotEngine) RenderMCPConfig(yaml *strings.Builder, tools map[string]
// Create unified renderer with Copilot-specific options
// Copilot uses JSON format with type and tools fields, and inline args
createRenderer := func(isLast bool) *MCPConfigRendererUnified {
actionMode := ActionModeDev // Default to dev mode
if workflowData != nil {
actionMode = workflowData.ActionMode
}
return NewMCPConfigRenderer(MCPRendererOptions{
IncludeCopilotFields: true, // Copilot uses "type" and "tools" fields
InlineArgs: true, // Copilot uses inline args format
Format: "json",
IsLast: isLast,
ActionMode: actionMode,
})
}

Expand Down
5 changes: 5 additions & 0 deletions pkg/workflow/custom_engine.go
Original file line number Diff line number Diff line change
Expand Up @@ -253,11 +253,16 @@ func (e *CustomEngine) RenderMCPConfig(yaml *strings.Builder, tools map[string]a
// Create unified renderer with Custom engine-specific options
// Custom engine uses JSON format without Copilot-specific fields and multi-line args (like Claude)
createRenderer := func(isLast bool) *MCPConfigRendererUnified {
actionMode := ActionModeDev // Default to dev mode
if workflowData != nil {
actionMode = workflowData.ActionMode
}
return NewMCPConfigRenderer(MCPRendererOptions{
IncludeCopilotFields: false, // Custom engine doesn't use "type" and "tools" fields
InlineArgs: false, // Custom engine uses multi-line args format
Format: "json",
IsLast: isLast,
ActionMode: actionMode,
})
}

Expand Down
5 changes: 3 additions & 2 deletions pkg/workflow/importable_tools_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -229,8 +229,9 @@ Uses imported agentic-workflows tool.
workflowData := string(lockFileContent)

// Verify containerized agentic_workflows server is present (per MCP Gateway Specification v1.0.0)
if !strings.Contains(workflowData, `"entrypointArgs": ["mcp-server"]`) {
t.Error("Expected compiled workflow to contain 'mcp-server' entrypointArgs")
// In dev mode (default), should include --cmd argument
if !strings.Contains(workflowData, `"entrypointArgs": ["mcp-server", "--cmd", "/opt/gh-aw/gh-aw"]`) {
t.Error("Expected compiled workflow to contain 'mcp-server' entrypointArgs with --cmd in dev mode")
}

// Verify container format is used (not command format)
Expand Down
Loading
Loading