[code-simplifier] Extract action mode helper to reduce code duplication

[github-actions]

Code Simplification - 2026-02-05

This PR simplifies recently modified code to improve clarity, consistency, and maintainability while preserving all functionality.

Files Simplified

• pkg/workflow/action_mode.go - Added GetActionModeFromWorkflowData() helper function
• pkg/workflow/copilot_mcp.go - Simplified createRenderer closure to use helper
• pkg/workflow/claude_mcp.go - Simplified createRenderer closure to use helper
• pkg/workflow/codex_mcp.go - Simplified createRenderer closure to use helper
• pkg/workflow/custom_engine.go - Simplified createRenderer closure to use helper

Improvements Made

1. Reduced Duplication

   • Extracted repeated 4-line conditional pattern into single helper function
   • Eliminated duplicate code across all four engine MCP renderers
   • Reduced 16 lines of duplicate code to 8 lines (1 helper function + 4 single-line calls)

2. Enhanced Clarity

   • Cleaner, more readable createRenderer closures
   • Single point of truth for action mode extraction logic
   • Explicit function name documents intent

3. Applied Project Standards

   • Follows Go convention of extracting repeated patterns
   • Maintains explicit, readable code over compact code
   • Improves maintainability without sacrificing clarity

Changes Based On

Recent changes from:

• Add --cmd argument to agentic-workflows MCP server in dev mode #13974 - Add --cmd argument to agentic-workflows MCP server in dev mode
• Commit ab9e530 - Introduced action mode propagation to MCP renderers

Testing

The changes are purely structural and preserve exact functionality:

• ✅ No functional changes - behavior is identical
• ✅ Same action mode extraction logic, just refactored
• ✅ All four engine renderers maintain original behavior
• ✅ Helper function follows existing patterns in action_mode.go

Review Focus

Please verify:

• Functionality is preserved (action mode extraction works identically)
• Simplification improves code quality and maintainability
• Helper function follows project conventions
• No unintended side effects from the refactoring

---

Context: This simplification addresses code duplication introduced in PR #13974, which added ActionMode propagation to MCP renderers. All four engine files (Copilot, Claude, Codex, Custom) had identical 4-line blocks for extracting action mode from workflow data. This PR consolidates that logic into a single, reusable helper function.

Benefits:

• Maintainability: Changes to action mode extraction logic now only need to be made in one place
• Readability: Cleaner code with less visual clutter in each renderer
• Consistency: Ensures all engines handle action mode extraction identically

Testing Strategy: Since this is a pure refactoring with no behavioral changes, the existing test suite validates correctness. The helper function uses the same logic (nil check with default to ActionModeDev) that was previously inline in each file.

AI generated by Code Simplifier

• expires on Feb 6, 2026, 8:00 PM UTC

[Copilot]

Pull request overview

This PR simplifies code by extracting a repeated 4-line pattern into a single helper function, improving maintainability while preserving all functionality. The refactoring addresses code duplication introduced in PR #13974, which added ActionMode propagation to MCP renderers.

Changes:

• Added GetActionModeFromWorkflowData() helper function to centralize action mode extraction logic
• Updated all four engine MCP renderers (Copilot, Claude, Codex, Custom) to use the new helper
• Reduced 16 lines of duplicate code to 8 lines total (1 helper + 4 single-line calls)

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
pkg/workflow/action_mode.go	Added GetActionModeFromWorkflowData() helper function with nil-check and default to dev mode
pkg/workflow/copilot_mcp.go	Simplified createRenderer closure to use helper function instead of inline nil-check
pkg/workflow/claude_mcp.go	Simplified createRenderer closure to use helper function instead of inline nil-check
pkg/workflow/codex_mcp.go	Simplified createRenderer closure to use helper function instead of inline nil-check
pkg/workflow/custom_engine.go	Simplified createRenderer closure to use helper function instead of inline nil-check

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.