Skip to content

Remove duplicate filename display in displayFileContent#13999

Merged
pelikhan merged 2 commits intomainfrom
copilot/update-file-content-display
Feb 5, 2026
Merged

Remove duplicate filename display in displayFileContent#13999
pelikhan merged 2 commits intomainfrom
copilot/update-file-content-display

Conversation

Copy link
Contributor

Copilot AI commented Feb 5, 2026

The displayFileContent function displayed filenames twice: once as an info line and again as the collapsible group title.

Changes

  • Consolidated filename and size into the startGroup() call only
  • Removed the separate core.info() line that duplicated the filename
  • Updated special case messages (empty files, unsupported types, too large files) to include filename consistently

Before

core.info(`  ${fileName} (${stats.size} bytes)`);  // First display
// ... checks ...
core.startGroup(fileName);  // Second display (duplicate)

After

// ... checks ...
core.startGroup(`${fileName} (${stats.size} bytes)`);  // Single display

Special cases now format consistently: ${fileName} (empty file), ${fileName} (content not displayed for .pdf files), etc.

Original prompt

Update javascript displayFileContent to avoid duplicating the filename as a title and in the region.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

- Remove duplicate filename display before content group
- Include file size in the collapsible group title instead
- Update special case messages to include filename
- Update all tests to check startGroup calls for filename
- All 18 tests passing

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Update displayFileContent to avoid filename duplication Remove duplicate filename display in displayFileContent Feb 5, 2026
Copilot AI requested a review from pelikhan February 5, 2026 22:01
@pelikhan pelikhan marked this pull request as ready for review February 5, 2026 22:06
Copilot AI review requested due to automatic review settings February 5, 2026 22:06
@pelikhan pelikhan merged commit 3787e75 into main Feb 5, 2026
151 of 152 checks passed
@pelikhan pelikhan deleted the copilot/update-file-content-display branch February 5, 2026 22:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes duplicate filename display in the displayFileContent function. Previously, the function displayed filenames twice: once via core.info() and again as the collapsible group title. The changes consolidate all filename displays into a single location - either in the startGroup() call for displayable files, or in a single core.info() call for special cases (empty files, unsupported types, or files too large to display).

Changes:

  • Removed the duplicate core.info() line that displayed file size information before content display
  • Updated startGroup() call to include both filename and size in the title
  • Consolidated special case messages (empty, too large, unsupported types) to include filename in a single info line

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
actions/setup/js/display_file_helpers.cjs Removed duplicate filename display; consolidated filename and size into startGroup() title; updated special case messages to include filename
actions/setup/js/display_file_helpers.test.cjs Updated all tests to verify filename appears in startGroup() calls instead of separate info() calls; updated special case test expectations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants