Conversation
The test "prints all files in gateway directories with content" was failing because it expected filenames to appear in core.info() output. However, the displayFileContent() function places filenames in core.startGroup() calls (as group titles) for files with displayable content, not in core.info() calls. Fixed by updating the test to check allGroups (startGroup calls) instead of allOutput (info calls) for filenames, which correctly reflects the actual function behavior. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions workflow for JavaScript
Fix test assertions in parse_mcp_gateway_log.test.cjs
Feb 5, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes failing test assertions in parse_mcp_gateway_log.test.cjs by correcting where filename assertions should look. The test was checking allOutput (info calls) for filenames, but the displayFileContent() function actually places filenames in allGroups (startGroup calls) as collapsible group titles.
Changes:
- Updated test assertions to check
allGroupsinstead ofallOutputfor filename presence - Removed redundant filename check that duplicated an existing assertion
- Improved test comment clarity to explain why filenames appear in startGroup calls
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test failure in
parse_mcp_gateway_log.test.cjs: assertions were checkingcore.info()output for filenames, butdisplayFileContent()places filenames incore.startGroup()calls as collapsible group titles.Changes:
allGroups(startGroup calls) instead ofallOutput(info calls) for filename assertionsFile content continues to be verified in
allOutputas expected.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.