[WIP] Fix MCP server permission denied error for testing

pkg/constants/constants.go

@@ -538,6 +538,9 @@ const SafeOutputsMCPServerID = "safeoutputs"
 // SafeInputsMCPServerID is the identifier for the safe-inputs MCP server
 const SafeInputsMCPServerID = "safeinputs"
 
+// AgenticWorkflowsMCPServerID is the identifier for the agentic-workflows MCP server
+const AgenticWorkflowsMCPServerID = "agenticworkflows"
+
 // SafeInputsMCPVersion is the version of the safe-inputs MCP server
 const SafeInputsMCPVersion = "1.0.0"
 

pkg/workflow/agentic_workflow_test.go

@@ -6,6 +6,7 @@ import (
 	"strings"
 	"testing"
 
+	"github.com/github/gh-aw/pkg/constants"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 )
@@ -121,8 +122,8 @@ func TestAgenticWorkflowsMCPConfigGeneration(t *testing.T) {
 			result := yaml.String()
 
 			// Verify the MCP config contains agentic-workflows
-			assert.Contains(t, result, "agentic_workflows",
-				"%s engine should generate MCP config with agentic_workflows server name", e.name)
+			assert.Contains(t, result, constants.AgenticWorkflowsMCPServerID,
+				"%s engine should generate MCP config with "+constants.AgenticWorkflowsMCPServerID+" server name", e.name)
 			assert.Contains(t, result, "gh",
 				"%s engine MCP config should use gh CLI command for agentic-workflows", e.name)
 			assert.Contains(t, result, "mcp-server",

pkg/workflow/importable_tools_test.go

@@ -8,8 +8,8 @@ import (
 	"strings"
 	"testing"
 
+	"github.com/github/gh-aw/pkg/constants"
 	"github.com/github/gh-aw/pkg/stringutil"
-
 	"github.com/github/gh-aw/pkg/testutil"
 	"github.com/github/gh-aw/pkg/workflow"
 )
@@ -342,7 +342,7 @@ Uses all imported tools.
 		t.Error("Expected compiled workflow to contain serena tool")
 	}
 	// Per MCP Gateway Specification v1.0.0, agentic-workflows uses containerized format
-	if !strings.Contains(workflowData, `"agentic_workflows"`) {
+	if !strings.Contains(workflowData, `"`+constants.AgenticWorkflowsMCPServerID+`"`) {
 		t.Error("Expected compiled workflow to contain agentic-workflows tool")
 	}
 

pkg/workflow/mcp_config_builtin.go

@@ -170,7 +170,7 @@ func renderAgenticWorkflowsMCPConfigWithOptions(yaml *strings.Builder, isLast bo
 	}
 
 	// Use MCP Gateway spec format with container, entrypoint, entrypointArgs, and mounts
-	yaml.WriteString("              \"agentic_workflows\": {\n")
+	yaml.WriteString("              \"" + constants.AgenticWorkflowsMCPServerID + "\": {\n")
 
 	// Add type field for Copilot (per MCP Gateway Specification v1.0.0, use "stdio" for containerized servers)
 	if includeCopilotFields {
@@ -286,7 +286,7 @@ func renderSafeOutputsMCPConfigTOML(yaml *strings.Builder) {
 // Uses MCP Gateway spec format: container, entrypoint, entrypointArgs, and mounts fields.
 func renderAgenticWorkflowsMCPConfigTOML(yaml *strings.Builder, actionMode ActionMode) {
 	yaml.WriteString("          \n")
-	yaml.WriteString("          [mcp_servers.agentic_workflows]\n")
+	yaml.WriteString("          [mcp_servers." + constants.AgenticWorkflowsMCPServerID + "]\n")
 
 	containerImage := constants.DefaultAlpineImage
 	var entrypoint string

pkg/workflow/mcp_config_refactor_test.go

@@ -5,6 +5,8 @@ package workflow
 import (
 	"strings"
 	"testing"
+
+	"github.com/github/gh-aw/pkg/constants"
 )
 
 // TestRenderSafeOutputsMCPConfigWithOptions verifies the shared Safe Outputs config helper
@@ -103,7 +105,7 @@ func TestRenderAgenticWorkflowsMCPConfigWithOptions(t *testing.T) {
 			includeCopilotFields: true,
 			actionMode:           ActionModeDev,
 			expectedContent: []string{
-				`"agentic_workflows": {`,
+				`"` + constants.AgenticWorkflowsMCPServerID + `": {`,
 				`"type": "stdio"`,
 				`"container": "localhost/gh-aw:dev"`,                   // Dev mode uses locally built image
 				`"${{ github.workspace }}:${{ github.workspace }}:rw"`, // workspace mount (read-write)
@@ -129,7 +131,7 @@ func TestRenderAgenticWorkflowsMCPConfigWithOptions(t *testing.T) {
 			includeCopilotFields: true,
 			actionMode:           ActionModeRelease,
 			expectedContent: []string{
-				`"agentic_workflows": {`,
+				`"` + constants.AgenticWorkflowsMCPServerID + `": {`,
 				`"type": "stdio"`,
 				`"container": "alpine:latest"`,
 				`"entrypoint": "/opt/gh-aw/gh-aw"`,
@@ -155,7 +157,7 @@ func TestRenderAgenticWorkflowsMCPConfigWithOptions(t *testing.T) {
 			includeCopilotFields: false,
 			actionMode:           ActionModeDev,
 			expectedContent: []string{
-				`"agentic_workflows": {`,
+				`"` + constants.AgenticWorkflowsMCPServerID + `": {`,
 				`"container": "localhost/gh-aw:dev"`,                   // Dev mode uses locally built image
 				`"${{ github.workspace }}:${{ github.workspace }}:rw"`, // workspace mount (read-write)
 				`"/tmp/gh-aw:/tmp/gh-aw:rw"`,                           // temp directory mount (read-write)
@@ -300,7 +302,7 @@ func TestRenderAgenticWorkflowsMCPConfigTOML(t *testing.T) {
 			result := output.String()
 
 			expectedContent := []string{
-				`[mcp_servers.agentic_workflows]`,
+				`[mcp_servers.` + constants.AgenticWorkflowsMCPServerID + `]`,
 				tt.expectedContainer,
 				`args = ["-w", "${{ github.workspace }}"]`, // Docker working directory
 				`env_vars = ["DEBUG", "GITHUB_TOKEN"]`,

pkg/workflow/mcp_renderer.go

@@ -412,7 +412,7 @@ func (r *MCPConfigRendererUnified) RenderAgenticWorkflowsMCP(yaml *strings.Build
 // Per MCP Gateway Specification v1.0.0 section 3.2.1, stdio-based MCP servers MUST be containerized.
 func (r *MCPConfigRendererUnified) renderAgenticWorkflowsTOML(yaml *strings.Builder) {
 	yaml.WriteString("          \n")
-	yaml.WriteString("          [mcp_servers.agentic_workflows]\n")
+	yaml.WriteString("          [mcp_servers." + constants.AgenticWorkflowsMCPServerID + "]\n")
 
 	containerImage := constants.DefaultAlpineImage
 	var entrypoint string

pkg/workflow/mcp_renderer_test.go

@@ -5,6 +5,8 @@ package workflow
 import (
 	"strings"
 	"testing"
+
+	"github.com/github/gh-aw/pkg/constants"
 )
 
 func TestNewMCPConfigRenderer(t *testing.T) {
@@ -181,8 +183,8 @@ func TestRenderAgenticWorkflowsMCP_JSON_Copilot(t *testing.T) {
 	if !strings.Contains(output, `"type": "stdio"`) {
 		t.Error("Expected 'type': 'stdio' field per MCP Gateway Specification")
 	}
-	if !strings.Contains(output, `"agentic_workflows": {`) {
-		t.Error("Expected agentic_workflows server ID")
+	if !strings.Contains(output, `"`+constants.AgenticWorkflowsMCPServerID+`": {`) {
+		t.Error("Expected " + constants.AgenticWorkflowsMCPServerID + " server ID")
 	}
 	// Per MCP Gateway Specification v1.0.0, stdio servers MUST use container format
 	// In dev mode, should use locally built image
@@ -255,8 +257,9 @@ func TestRenderAgenticWorkflowsMCP_TOML(t *testing.T) {
 	output := yaml.String()
 
 	// Verify TOML format (per MCP Gateway Specification v1.0.0)
-	if !strings.Contains(output, "[mcp_servers.agentic_workflows]") {
-		t.Error("Expected TOML section header")
+	expectedHeader := `[mcp_servers.` + constants.AgenticWorkflowsMCPServerID + `]`
+	if !strings.Contains(output, expectedHeader) {
+		t.Errorf("Expected TOML section header: %s", expectedHeader)
 	}
 	// Per MCP Gateway Specification v1.0.0, stdio servers MUST use container format
 	// In dev mode, should use locally built image