Skip to content

Fix TestRuntimeSetupPreservesUserVersions false positive from AWF version #14221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 4 commits into from
Feb 6, 2026
+239 −109
Merged

Fix TestRuntimeSetupPreservesUserVersions false positive from AWF version #14221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7b0ecec
Initial plan
Copilot Feb 6, 2026
60c11dc
Initial analysis: Test false positive due to string matching
Copilot Feb 6, 2026
5393e59
Fix TestRuntimeSetupPreservesUserVersions false positive
Copilot Feb 6, 2026
3c7df1b
Merge branch 'main' into copilot/fix-github-actions-workflow-3eb85ab4…
pelikhan Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/daily-cli-tools-tester.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions .github/workflows/dependabot-project-manager.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions pkg/workflow/runtime_setup_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,8 +294,9 @@ steps:
t.Error("Expected to preserve user's Python version 3.9")
}

// Should not add default version (3.12)
if strings.Contains(lockContent, "3.12") {
// Should not add default version (3.12) - check specifically for python-version to avoid
// false positives from other version strings like AWF version "0.13.12"
if strings.Contains(lockContent, `python-version: '3.12'`) || strings.Contains(lockContent, `python-version: "3.12"`) {
t.Error("Should not override user's version with default version")
Comment on lines +297 to 300
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The negative assertion only checks for quoted forms of 3.12. If the lockfile emitter ever outputs python-version: 3.12 (unquoted) this test would miss the regression. Consider matching python-version: with optional quotes/whitespace (e.g., via regexp) and/or reusing the non-comment-line helpers so the check is robust to YAML formatting changes.

Copilot uses AI. Check for mistakes.
}

Expand Down
Loading
Loading