Fix plugin command syntax: install plugin → plugin install#14224
Fix plugin command syntax: install plugin → plugin install#14224
install plugin → plugin install#14224Conversation
…stall' Co-authored-by: patrickcarnahan <17889693+patrickcarnahan@users.noreply.github.com>
…stall' Fix the plugin CLI command syntax to use the correct subcommand ordering. Confirmed: copilot uses 'copilot plugin install <repo>'. Added TODO comments for claude and codex CLI syntax validation. Co-authored-by: patrickcarnahan <17889693+patrickcarnahan@users.noreply.github.com>
install plugin → plugin install
There was a problem hiding this comment.
Pull request overview
Fixes the generated CLI command ordering for plugin installation so workflows run the correct subcommand sequence (<engine> plugin install <repo>), and updates tests/docs accordingly.
Changes:
- Updated plugin install command generation from
install plugintoplugin installacross supported engines. - Updated unit/integration test expectations for compiled plugin install commands.
- Updated frontmatter documentation to reflect the corrected plugin install syntax (plus minor docs/lockfile updates).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/plugin_installation.go | Changes the generated plugin installation command format to plugin install. |
| pkg/workflow/plugin_installation_test.go | Updates expected command strings/assertions for plugin install steps. |
| pkg/workflow/plugin_compilation_test.go | Updates compiled lockfile assertions to match the new plugin command ordering. |
| docs/src/content/docs/reference/frontmatter.md | Updates docs to describe copilot/claude/codex plugin install syntax. |
| docs/src/content/docs/agent-factory-status.mdx | Adds a workflow entry for “Dependabot Project Manager”. |
| .github/workflows/dependabot-project-manager.lock.yml | Regenerated lockfile content (includes awf/firewall version bump to 0.13.12). |
| .github/workflows/daily-cli-tools-tester.lock.yml | Regenerated lockfile content (includes awf/firewall version bump to 0.13.12). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -185,7 +185,7 @@ jobs: | |||
| const determineAutomaticLockdown = require('/opt/gh-aw/actions/determine_automatic_lockdown.cjs'); | |||
| await determineAutomaticLockdown(github, context, core); | |||
| - name: Download container images | |||
| run: bash /opt/gh-aw/actions/download_docker_images.sh ghcr.io/github/gh-aw-firewall/agent:0.13.7 ghcr.io/github/gh-aw-firewall/squid:0.13.7 ghcr.io/github/gh-aw-mcpg:v0.0.103 ghcr.io/github/github-mcp-server:v0.30.3 node:lts-alpine | |||
| run: bash /opt/gh-aw/actions/download_docker_images.sh ghcr.io/github/gh-aw-firewall/agent:0.13.12 ghcr.io/github/gh-aw-firewall/squid:0.13.12 ghcr.io/github/gh-aw-mcpg:v0.0.103 ghcr.io/github/github-mcp-server:v0.30.3 node:lts-alpine | |||
There was a problem hiding this comment.
This lockfile change bumps awf + firewall image tags from 0.13.7 to 0.13.12. Since the PR is primarily about fixing plugin install command syntax, consider documenting this version bump in the PR description or moving it to a separate PR to avoid surprising operational changes.
| | [DeepReport - Intelligence Gathering Agent](https://github.com/github/gh-aw/blob/main/.github/workflows/deep-report.md) | codex | [](https://github.com/github/gh-aw/actions/workflows/deep-report.lock.yml) | `0 15 * * 1-5` | - | | ||
| | [Delight](https://github.com/github/gh-aw/blob/main/.github/workflows/delight.md) | copilot | [](https://github.com/github/gh-aw/actions/workflows/delight.lock.yml) | - | - | | ||
| | [Dependabot Dependency Checker](https://github.com/github/gh-aw/blob/main/.github/workflows/dependabot-go-checker.md) | copilot | [](https://github.com/github/gh-aw/actions/workflows/dependabot-go-checker.lock.yml) | `0 9 * * 1,3,5` | - | | ||
| | [Dependabot Project Manager](https://github.com/github/gh-aw/blob/main/.github/workflows/dependabot-project-manager.md) | copilot | [](https://github.com/github/gh-aw/actions/workflows/dependabot-project-manager.lock.yml) | - | - | |
There was a problem hiding this comment.
This docs page gains a new workflow entry (Dependabot Project Manager), but the PR description doesn’t mention this documentation update. Consider adding it to the PR’s change list (or splitting it) so reviewers understand why this page is being modified alongside the plugin command fix.
| ### Plugins (`plugins:`) | ||
|
|
||
| Specifies plugins to install before workflow execution. Plugins are installed using engine-specific CLI commands (`copilot install plugin`, `claude install plugin`, `codex install plugin`). | ||
| Specifies plugins to install before workflow execution. Plugins are installed using engine-specific CLI commands (`copilot plugin install`, `claude plugin install`, `codex plugin install`). |
There was a problem hiding this comment.
The docs state that plugins are installed using claude plugin install and codex plugin install, but the implementation currently includes TODOs indicating those syntaxes haven’t been validated. Either validate and remove the TODOs, or update this documentation to clearly caveat that only the Copilot syntax is confirmed (so users don’t treat Claude/Codex syntax as guaranteed).
| Specifies plugins to install before workflow execution. Plugins are installed using engine-specific CLI commands (`copilot plugin install`, `claude plugin install`, `codex plugin install`). | |
| Specifies plugins to install before workflow execution. Plugins are typically installed using engine-specific CLI commands. Currently, only the Copilot syntax (`copilot plugin install`) is validated; Claude (`claude plugin install`) and Codex (`codex plugin install`) syntaxes are experimental and may change—consult the engine’s documentation for the latest supported commands. |
| @@ -152,7 +152,7 @@ jobs: | |||
| const determineAutomaticLockdown = require('/opt/gh-aw/actions/determine_automatic_lockdown.cjs'); | |||
| await determineAutomaticLockdown(github, context, core); | |||
| - name: Download container images | |||
| run: bash /opt/gh-aw/actions/download_docker_images.sh ghcr.io/github/gh-aw-firewall/agent:0.13.7 ghcr.io/github/gh-aw-firewall/squid:0.13.7 ghcr.io/github/gh-aw-mcpg:v0.0.103 ghcr.io/github/github-mcp-server:v0.30.3 node:lts-alpine | |||
| run: bash /opt/gh-aw/actions/download_docker_images.sh ghcr.io/github/gh-aw-firewall/agent:0.13.12 ghcr.io/github/gh-aw-firewall/squid:0.13.12 ghcr.io/github/gh-aw-mcpg:v0.0.103 ghcr.io/github/github-mcp-server:v0.30.3 node:lts-alpine | |||
There was a problem hiding this comment.
This lockfile change bumps awf + firewall image tags from 0.13.7 to 0.13.12. That’s a behavioral/operational change that isn’t mentioned in the PR description (which focuses on plugin command ordering). Consider calling out this version bump explicitly in the PR description or splitting it into a separate PR to keep the change scope clear.
Plugin installation commands were generated with incorrect subcommand ordering (
copilot install plugin <repo>instead ofcopilot plugin install <repo>), causing CLI errors at runtime.Changes:
pkg/workflow/plugin_installation.go— Fixed command format for all engines; added TODO comments for claude/codex syntax validation (only copilot confirmed)pkg/workflow/plugin_installation_test.go/plugin_compilation_test.go— Updated expected command stringsdocs/src/content/docs/reference/frontmatter.md— Updated documented command syntaxBefore:
After:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.