Document SSL-bump feature for AWF firewall#14266
Conversation
- Document ssl-bump feature for HTTPS inspection - Add allow-urls parameter with URL pattern examples - Include security considerations and usage examples - Add "When to Use SSL Bump" guidance section - Place documentation after log-level section as requested Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds missing documentation for the AWF firewall’s SSL-bump (HTTPS inspection) capability in the network reference, aligning the docs with existing schema/code support.
Changes:
- Documented
network.firewall.ssl-bumpandnetwork.firewall.allow-urlsconfiguration options. - Added usage examples (including with
log-level) plus caution/tip guidance around HTTPS interception and when to use URL-path filtering.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - "https://github.com/githubnext/*" | ||
| - "https://api.github.com/repos/*/issues" | ||
| allowed: | ||
| - defaults |
There was a problem hiding this comment.
The first example enables ssl-bump with allow-urls, but the network.allowed list only contains defaults. In the compiler/engines AWF is still invoked with --allow-domains derived from network.allowed; allow-urls is additive and does not replace the domain allowlist. As written, this example would still block github.com/api.github.com unless those domains (or the github ecosystem) are included in network.allowed.
Suggestion: update this example to include the corresponding domains in network.allowed, or add an explicit note that allow-urls refines HTTPS access after the domain allowlist is satisfied.
| - defaults | |
| - defaults | |
| - github.com | |
| - api.github.com |
The AWF firewall's SSL-bump feature existed in schema and code but was undocumented in the network reference.
Changes
Added "SSL Bump for HTTPS Inspection" section to
docs/src/content/docs/reference/network.md:ssl-bump(boolean, enables HTTPS inspection) andallow-urls(array of HTTPS URL patterns with wildcard support)Example
Enables deep packet inspection of HTTPS traffic, allowing firewall to filter on URL paths instead of just domain names. Positioned after the log-level section to maintain logical flow with other firewall configuration options.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.