Skip to content

fix: remove trailing commas in smoke-project workflow instructions#14472

Merged
mnkiefer merged 2 commits intomnkiefer-patch-smokefrom
copilot/sub-pr-14455
Feb 8, 2026
Merged

fix: remove trailing commas in smoke-project workflow instructions#14472
mnkiefer merged 2 commits intomnkiefer-patch-smokefrom
copilot/sub-pr-14455

Conversation

Copy link
Contributor

Copilot AI commented Feb 8, 2026

Addresses review feedback on #14455 to remove trailing commas from project parameter values in workflow instructions that could be copied literally and cause invalid YAML/JSON.

Changes

  • Removed trailing comma from Pull Request Update section (line 108)
  • Removed trailing comma from Issue Update section (line 115)
  • Recompiled workflow to update .lock.yml file

Context

The instructions list update_project parameters as bullet points. Trailing commas after the project URL parameter were inconsistent with other parameters and could lead to malformed values if copied verbatim:

- `project`: "https://github.com/orgs/github-agentic-workflows/projects/1",  ❌
- `project`: "https://github.com/orgs/github-agentic-workflows/projects/1"   ✅

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix trailing comma in smoke-project workflow fix: remove trailing commas in smoke-project workflow instructions Feb 8, 2026
Copilot AI requested a review from mnkiefer February 8, 2026 07:06
@mnkiefer mnkiefer marked this pull request as ready for review February 8, 2026 07:08
Copilot AI review requested due to automatic review settings February 8, 2026 07:08
@mnkiefer mnkiefer merged commit 0dc8169 into mnkiefer-patch-smoke Feb 8, 2026
3 checks passed
@mnkiefer mnkiefer deleted the copilot/sub-pr-14455 branch February 8, 2026 07:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the smoke-project workflow instructions to avoid copy/paste-able trailing commas in update_project parameters, and recompiles the workflow to refresh the generated lockfile.

Changes:

  • Remove trailing commas from project parameter examples in the Pull Request Update and Issue Update instruction sections.
  • Recompile workflow to update the generated .lock.yml (including updated setup action wiring and frontmatter hash).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/smoke-project.md Removes trailing commas from project parameter bullets in instructions to prevent malformed copied values.
.github/workflows/smoke-project.lock.yml Regenerated compiled workflow output reflecting the updated markdown (and updated compiled setup step form).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- `content_number`: 18
- `fields`: `{"Status": "In Progress"}`

c. **Issue Update**:
Copy link

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "c. Issue Update" line is indented more than the preceding "a." and "b." items in the same numbered list. In Markdown, this can change list nesting/rendering (or even create a code block depending on context). Align the indentation with the other lettered sub-items to keep the list formatting consistent.

Suggested change
c. **Issue Update**:
c. **Issue Update**:

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants