fix: remove trailing commas in smoke-project workflow instructions#14472
fix: remove trailing commas in smoke-project workflow instructions#14472mnkiefer merged 2 commits intomnkiefer-patch-smokefrom
Conversation
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the smoke-project workflow instructions to avoid copy/paste-able trailing commas in update_project parameters, and recompiles the workflow to refresh the generated lockfile.
Changes:
- Remove trailing commas from
projectparameter examples in the Pull Request Update and Issue Update instruction sections. - Recompile workflow to update the generated
.lock.yml(including updated setup action wiring and frontmatter hash).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/smoke-project.md | Removes trailing commas from project parameter bullets in instructions to prevent malformed copied values. |
| .github/workflows/smoke-project.lock.yml | Regenerated compiled workflow output reflecting the updated markdown (and updated compiled setup step form). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - `content_number`: 18 | ||
| - `fields`: `{"Status": "In Progress"}` | ||
|
|
||
| c. **Issue Update**: |
There was a problem hiding this comment.
The "c. Issue Update" line is indented more than the preceding "a." and "b." items in the same numbered list. In Markdown, this can change list nesting/rendering (or even create a code block depending on context). Align the indentation with the other lettered sub-items to keep the list formatting consistent.
| c. **Issue Update**: | |
| c. **Issue Update**: |
Addresses review feedback on #14455 to remove trailing commas from
projectparameter values in workflow instructions that could be copied literally and cause invalid YAML/JSON.Changes
.lock.ymlfileContext
The instructions list
update_projectparameters as bullet points. Trailing commas after theprojectURL parameter were inconsistent with other parameters and could lead to malformed values if copied verbatim:💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.