Skip to content

Fix tests after sandbox: false deprecation#14895

Merged
pelikhan merged 3 commits intocopilot/remove-sandbox-supportfrom
copilot/fix-test-issue-again
Feb 11, 2026
Merged

Fix tests after sandbox: false deprecation#14895
pelikhan merged 3 commits intocopilot/remove-sandbox-supportfrom
copilot/fix-test-issue-again

Conversation

Copy link
Contributor

Copilot AI commented Feb 11, 2026

Tests failed after commit ec26873 removed sandbox: false support in favor of sandbox.agent: false. Error messages and YAML schema changed but tests weren't updated.

Changes

  • firewall_default_enablement_test.go: Updated error message assertions from "sandbox: false" to "sandbox.agent: false"
  • workflow_run_validation_test.go:
    • Replaced invalid sandbox: false with sandbox.agent: false in test frontmatter (7 test cases)
    • Adjusted warning count expectations (sandbox.agent: false generates warnings, old sandbox: false didn't)

Example

Before (invalid YAML):

tools:
  github: false
sandbox: false  # Schema error: expected string or object

After (valid):

tools:
  github: false
sandbox:
  agent: false  # Disables agent firewall only
Original prompt

Reference: https://github.com/github/gh-aw/actions/runs/21893886862/job/63206326223#step:9:1

Fix test


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 2 commits February 11, 2026 05:54
- Update firewall_default_enablement_test.go to check for "sandbox.agent: false" instead of "sandbox: false" in error messages
- Update workflow_run_validation_test.go to use sandbox.agent: false instead of deprecated sandbox: false
- Adjust warning counts to account for sandbox.agent: false warnings

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
All originally failing tests now pass:
- TestStrictModeFirewallValidation: ✓
- TestWorkflowRunBranchValidation: ✓
- TestWorkflowRunBranchValidationEdgeCases: ✓

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix test failure in test suite Fix tests after sandbox: false deprecation Feb 11, 2026
Copilot AI requested a review from pelikhan February 11, 2026 06:03
@pelikhan pelikhan marked this pull request as ready for review February 11, 2026 06:09
Copilot AI review requested due to automatic review settings February 11, 2026 06:09
@pelikhan pelikhan merged commit e5037aa into copilot/remove-sandbox-support Feb 11, 2026
6 checks passed
@pelikhan pelikhan deleted the copilot/fix-test-issue-again branch February 11, 2026 06:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes test failures caused by the deprecation of sandbox: false in commit ec26873. The old top-level boolean format has been replaced with sandbox.agent: false, which only disables the agent firewall while keeping the MCP gateway enabled.

Changes:

  • Updated test assertions to expect the new error message format "sandbox.agent: false" instead of "sandbox: false"
  • Fixed invalid YAML in test fixtures by replacing sandbox: false with the correct nested structure sandbox:\n agent: false
  • Updated documentation to reflect the removal of the top-level boolean option and document the new sandbox.agent: false format

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
pkg/workflow/workflow_run_validation_test.go Updated 7 test cases to use valid sandbox.agent: false YAML and corrected warning count comments
pkg/workflow/firewall_default_enablement_test.go Updated error message assertions to expect "sandbox.agent: false" instead of "sandbox: false"
docs/src/content/docs/reference/frontmatter-full.md Removed deprecated sandbox: false option documentation and clarified that MCP gateway is always enabled

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants