Fix tests after sandbox: false deprecation#14895
Merged
pelikhan merged 3 commits intocopilot/remove-sandbox-supportfrom Feb 11, 2026
Merged
Fix tests after sandbox: false deprecation#14895pelikhan merged 3 commits intocopilot/remove-sandbox-supportfrom
pelikhan merged 3 commits intocopilot/remove-sandbox-supportfrom
Conversation
- Update firewall_default_enablement_test.go to check for "sandbox.agent: false" instead of "sandbox: false" in error messages - Update workflow_run_validation_test.go to use sandbox.agent: false instead of deprecated sandbox: false - Adjust warning counts to account for sandbox.agent: false warnings Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
All originally failing tests now pass: - TestStrictModeFirewallValidation: ✓ - TestWorkflowRunBranchValidation: ✓ - TestWorkflowRunBranchValidationEdgeCases: ✓ Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix test failure in test suite
Fix tests after sandbox: false deprecation
Feb 11, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes test failures caused by the deprecation of sandbox: false in commit ec26873. The old top-level boolean format has been replaced with sandbox.agent: false, which only disables the agent firewall while keeping the MCP gateway enabled.
Changes:
- Updated test assertions to expect the new error message format
"sandbox.agent: false"instead of"sandbox: false" - Fixed invalid YAML in test fixtures by replacing
sandbox: falsewith the correct nested structuresandbox:\n agent: false - Updated documentation to reflect the removal of the top-level boolean option and document the new
sandbox.agent: falseformat
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/workflow/workflow_run_validation_test.go | Updated 7 test cases to use valid sandbox.agent: false YAML and corrected warning count comments |
| pkg/workflow/firewall_default_enablement_test.go | Updated error message assertions to expect "sandbox.agent: false" instead of "sandbox: false" |
| docs/src/content/docs/reference/frontmatter-full.md | Removed deprecated sandbox: false option documentation and clarified that MCP gateway is always enabled |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests failed after commit
ec26873removedsandbox: falsesupport in favor ofsandbox.agent: false. Error messages and YAML schema changed but tests weren't updated.Changes
firewall_default_enablement_test.go: Updated error message assertions from"sandbox: false"to"sandbox.agent: false"workflow_run_validation_test.go:sandbox: falsewithsandbox.agent: falsein test frontmatter (7 test cases)sandbox.agent: falsegenerates warnings, oldsandbox: falsedidn't)Example
Before (invalid YAML):
After (valid):
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.