Skip to content

MCP SDK v1.3.0: Add client logging and document schema caching #15127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 3 commits into from
Feb 12, 2026
Merged

MCP SDK v1.3.0: Add client logging and document schema caching #15127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d1ed3c
Initial plan
Copilot Feb 12, 2026
85eb6e0
Initial plan for MCP SDK improvements
Copilot Feb 12, 2026
be79349
Add logger to MCP client connections and document schema caching
Copilot Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci-doctor.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/sub-issue-closer.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/workflow-health-manager.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 7 additions & 3 deletions pkg/cli/mcp_inspect_mcp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,9 @@ func connectStdioMCPServer(ctx context.Context, config parser.MCPServerConfig, v
}

// Create MCP client and connect
client := mcp.NewClient(&mcp.Implementation{Name: "gh-aw-inspector", Version: "1.0.0"}, nil)
client := mcp.NewClient(&mcp.Implementation{Name: "gh-aw-inspector", Version: "1.0.0"}, &mcp.ClientOptions{
Logger: logger.NewSlogLoggerWithHandler(mcpInspectServerLog),
})
transport := &mcp.CommandTransport{Command: cmd}

// Create a timeout context for connection
Expand Down Expand Up @@ -246,8 +248,10 @@ func connectHTTPMCPServer(ctx context.Context, config parser.MCPServerConfig, ve
fmt.Fprintln(os.Stderr, console.FormatInfoMessage(fmt.Sprintf("Connecting to HTTP MCP server: %s", config.URL)))
}

// Create MCP client
client := mcp.NewClient(&mcp.Implementation{Name: "gh-aw-inspector", Version: "1.0.0"}, nil)
// Create MCP client with logger for better debugging
client := mcp.NewClient(&mcp.Implementation{Name: "gh-aw-inspector", Version: "1.0.0"}, &mcp.ClientOptions{
Logger: logger.NewSlogLoggerWithHandler(mcpInspectServerLog),
})

// Create streamable client transport for HTTP
transport := &mcp.StreamableClientTransport{
Expand Down
1 change: 1 addition & 0 deletions pkg/cli/mcp_server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ func createMCPServer(cmdPath string) *mcp.Server {
}

// Create MCP server with capabilities and logging
// Note: Schema caching is automatic in go-sdk v1.3.0+ (eliminates repeated reflection overhead)
server := mcp.NewServer(&mcp.Implementation{
Name: "gh-aw",
Version: GetVersion(),
Expand Down
5 changes: 5 additions & 0 deletions pkg/workflow/data/action_pins.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,11 @@
"version": "v4.3.1",
"sha": "67a3573c9a986a3f9c594539f4ab511d57bb3ce9"
},
"actions/setup-go@v5": {
"repo": "actions/setup-go",
"version": "v5",
"sha": "40f1582b2485089dde7abd97c1529aa768e1baff"
},
Comment on lines +68 to +72
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR changes action_pins.json by adding a new pin for actions/setup-go@v5, but the PR description focuses on MCP SDK logging/schema caching. If this is an intended side-effect of running workflow recompilation (e.g., needed by daily-syntax-error-quality.md), please call it out in the PR description or split these workflow-compilation artifacts into a separate PR to keep the change set focused.

Copilot uses AI. Check for mistakes.
"actions/setup-go@v6.2.0": {
"repo": "actions/setup-go",
"version": "v6.2.0",
Expand Down
Loading