Remove legacy generateFooter

[strawgate]

Fixes #15564 and ensures that the footer can be customized no matter where it's used

[Copilot]

Pull request overview

This PR standardizes footer generation across the codebase by migrating from the legacy generateFooter function to generateFooterWithMessages, which uses the messages.footer configuration instead of hardcoded footer files.

Changes:

• Replaced all imports and calls to generateFooter from generate_footer.cjs with generateFooterWithMessages from messages_footer.cjs
• Removed the legacy generateFooter function implementation and its associated file-reading logic from generate_footer.cjs
• Updated test files to remove test setup for the legacy prompts directory and file-based footer templates

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
actions/setup/js/pr_review_buffer.cjs	Updated import to use generateFooterWithMessages instead of legacy generateFooter
actions/setup/js/mark_pull_request_as_ready_for_review.cjs	Updated import and function call to use generateFooterWithMessages
actions/setup/js/create_issue.cjs	Updated import to use generateFooterWithMessages and split imports to keep generateWorkflowIdMarker from generate_footer.cjs
actions/setup/js/close_pull_request.cjs	Updated import to use generateFooterWithMessages
actions/setup/js/close_entity_helpers.cjs	Updated import to use generateFooterWithMessages
actions/setup/js/generate_footer.cjs	Removed legacy generateFooter function, file system dependencies, and related helper imports
actions/setup/js/generate_footer.test.cjs	Removed all tests for the legacy generateFooter function and associated test setup for prompts directory
actions/setup/js/pr_review_buffer.test.cjs	Updated test setup to use GH_AW_SAFE_OUTPUT_MESSAGES environment variable instead of creating temporary prompts directory files

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[pelikhan]

• show a diff of the rendering of the footer
• compare features in deprecated and new version. make sure all features (like domains) are present

[strawgate]

1. Rendered footer diff

Old (generateFooter) — no custom messages configured:

> AI generated by [my-workflow](https://github.com/owner/repo/actions/runs/123) for #42
>
> To add this workflow in your repository, run `gh aw add owner/repo/workflow.md@main`. See [usage guide](https://github.github.com/gh-aw/guides/packaging-imports/).

⚠️ Firewall blocked domains: example.com (if applicable)

<!-- gh-aw-agentic-workflow: my-workflow, run: https://github.com/owner/repo/actions/runs/123 -->

New (generateFooterWithMessages) — no custom messages configured:

> Generated by [my-workflow](https://github.com/owner/repo/actions/runs/123) for issue #42
>
> To install this workflow, run `gh aw add owner/repo/workflow.md@main`. View source at [https://github.com/owner/repo/blob/main/workflow.md](https://github.com/owner/repo/blob/main/workflow.md).

⚠️ Firewall blocked domains: example.com (if applicable)

<!-- gh-aw-agentic-workflow: my-workflow, run: https://github.com/owner/repo/actions/runs/123 -->

Text differences in defaults:

Element	Old	New
Attribution prefix	> AI generated by	> Generated by
Triggering ref	for #42	for issue #42
Install verb	"To add this workflow"	"To install this workflow"
Install link	"See usage guide"	"View source at [url]"

Note: add_comment.cjs and check_workflow_recompile_needed.cjs were already using generateFooterWithMessages before this PR, so the codebase was already producing mixed footer text. This PR makes it consistent.

2. Feature comparison

Feature	Old (generateFooter)	New (generateFooterWithMessages)	Status
Footer attribution	Hardcoded > AI generated by	Configurable via messages.footer (default: > Generated by)	✅ Present + customizable
Triggering reference (issue/PR/discussion)	for #N / for discussion #N	for issue #N / for issue #discussion #N	✅ Present
Install instructions	Read from $GH_AW_PROMPTS_DIR/workflow_install_note.md	Configurable via messages.footerInstall (has default)	✅ Present + customizable
Missing tools/data sections (getMissingInfoSections)	✅	✅	✅ Same code path
Blocked domains section (getBlockedDomains + generateBlockedDomainsSection)	✅	✅	✅ Same code path
XML marker (generateXMLMarker)	✅	✅	✅ Same code path
Custom messages.footer template support	❌ Not supported	✅ Supported	🆕 Added
Custom messages.footerInstall template support	❌ Not supported	✅ Supported	🆕 Added

All features from the old version are present. The new version adds customizability via messages.footer and messages.footerInstall templates — which was the motivation for this migration.

[pelikhan]

Looks good. Some test fixes needed.

[strawgate]

looks like the same tests are failing on main #15568