Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
86 changes: 44 additions & 42 deletions .github/workflows/grumpy-reviewer.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 11 additions & 3 deletions .github/workflows/grumpy-reviewer.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@ tools:
lockdown: true
toolsets: [pull_requests, repos]
safe-outputs:
add-comment:
max: 1
create-pull-request-review-comment:
max: 5
side: "RIGHT"
submit-pull-request-review:
max: 1
messages:
footer: "> 😤 *Reluctantly reviewed by [{workflow_name}]({run_url})*"
run-started: "😤 *sigh* [{workflow_name}]({run_url}) is begrudgingly looking at this {event_type}... This better be worth my time."
Expand Down Expand Up @@ -102,7 +102,15 @@ If the code is actually good:
- "Surprisingly not terrible. The error handling is actually present."
- "Huh. This is clean. Did AI actually write something decent?"

### Step 5: Update Memory
### Step 5: Submit the Review

Submit a review using `submit_pull_request_review` with your overall verdict. Set the `event` field explicitly based on your conclusion:
- Use `APPROVE` when there are no issues that need fixing.
- Use `REQUEST_CHANGES` when there are issues that must be fixed before merging.
- (Optionally) use `COMMENT` when you only have non-blocking observations.
Keep the overall review comment brief and grumpy.

### Step 6: Update Memory

Save your review to cache memory:
- Write a summary to `/tmp/gh-aw/cache-memory/pr-${{ github.event.issue.number }}.json` including:
Expand Down
82 changes: 44 additions & 38 deletions .github/workflows/pr-nitpick-reviewer.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 4 additions & 5 deletions .github/workflows/pr-nitpick-reviewer.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ safe-outputs:
title-prefix: "[nitpick-report] "
category: "general"
max: 1
add-comment:
max: 3
create-pull-request-review-comment:
max: 10
side: "RIGHT"
submit-pull-request-review:
max: 1
messages:
footer: "> 🔍 *Meticulously inspected by [{workflow_name}]({run_url})*"
run-started: "🔬 Adjusting monocle... [{workflow_name}]({run_url}) is scrutinizing every pixel of this {event_type}..."
Expand Down Expand Up @@ -167,7 +167,7 @@ For each nitpick found, decide on the appropriate output type:
- Keep comments constructive and helpful
- Maximum 10 review comments (most important issues)

#### Use `add-comment` for:
#### Use `submit_pull_request_review` for:
- **General observations** - Overall patterns across the PR
- **Summary feedback** - High-level themes
- **Appreciation** - Acknowledgment of good practices
Expand All @@ -179,11 +179,10 @@ For each nitpick found, decide on the appropriate output type:
}
```

**Guidelines for PR comments:**
**Guidelines for review submission:**
- Provide overview and context
- Group related nitpicks into themes
- Acknowledge good practices
- Maximum 3 PR comments total

#### Use `create-discussion` for:
- **Daily/weekly summary report** - Comprehensive markdown report
Expand Down
Loading
Loading