Skip to content

[code-simplifier] Simplify locked resource error check logic #15977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
github-actions wants to merge 1 commit into from
Closed

[code-simplifier] Simplify locked resource error check logic #15977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions actions/setup/js/add_reaction.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,12 +100,10 @@ async function main() {

// Check if the error is due to a locked issue/PR/discussion
// GitHub API returns 403 with specific messages for locked resources
const is403Error = error && typeof error === "object" && "status" in error && error.status === 403;
const hasLockedMessage = errorMessage && (errorMessage.includes("locked") || errorMessage.includes("Lock conversation"));

// Only ignore the error if it's a 403 AND mentions locked, or if the message mentions locked
if ((is403Error && hasLockedMessage) || (!is403Error && hasLockedMessage)) {
// Silently ignore locked resource errors - just log for debugging
// Silently ignore locked resource errors regardless of status code
if (hasLockedMessage) {
core.info(`Cannot add reaction: resource is locked (this is expected and not an error)`);
return;
}
Expand Down
6 changes: 2 additions & 4 deletions actions/setup/js/add_reaction_and_edit_comment.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,12 +158,10 @@ async function main() {

// Check if the error is due to a locked issue/PR/discussion
// GitHub API returns 403 with specific messages for locked resources
const is403Error = error && typeof error === "object" && "status" in error && error.status === 403;
const hasLockedMessage = errorMessage && (errorMessage.includes("locked") || errorMessage.includes("Lock conversation"));

// Only ignore the error if it's a 403 AND mentions locked, or if the message mentions locked
if ((is403Error && hasLockedMessage) || (!is403Error && hasLockedMessage)) {
// Silently ignore locked resource errors - just log for debugging
// Silently ignore locked resource errors regardless of status code
if (hasLockedMessage) {
core.info(`Cannot add reaction: resource is locked (this is expected and not an error)`);
return;
}
Expand Down