Align update_project schema patterns with handler implementation for # prefix support#16104
Merged
mnkiefer merged 2 commits intofix-tmp-idsfrom Feb 16, 2026
Merged
Align update_project schema patterns with handler implementation for # prefix support#16104mnkiefer merged 2 commits intofix-tmp-idsfrom
mnkiefer merged 2 commits intofix-tmp-idsfrom
Conversation
…y_id patterns
Align pkg/workflow/js/safe_outputs_tools.json schema with actions/setup/js/safe_outputs_tools.json
and the update_project handler implementation which already accepts and strips # prefix.
Changes:
- Update draft_issue_id pattern from ^aw_[A-Za-z0-9]{3,8}$ to ^#?aw_[A-Za-z0-9]{3,8}$
- Update temporary_id pattern from ^aw_[A-Za-z0-9]{3,8}$ to ^#?aw_[A-Za-z0-9]{3,8}$
- Update descriptions to reflect optional # prefix support
Fixes schema validation failures for inputs like #aw_abc123 that work at runtime.
Addresses: #16098 (comment)
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Update ID pattern cleanup and project logic implementation
Align update_project schema patterns with handler implementation for # prefix support
Feb 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a schema validation mismatch where the compile-time schema rejected temporary IDs with a leading # prefix (e.g., #aw_abc123) while the runtime schema and handler implementation accepted them. The fix ensures consistent validation across the compile-time and runtime environments for the update_project tool's draft issue fields.
Changes:
- Updated
draft_issue_idpattern from^aw_[A-Za-z0-9]{3,8}$to^#?aw_[A-Za-z0-9]{3,8}$to allow optional#prefix - Updated
temporary_idpattern from^aw_[A-Za-z0-9]{3,8}$to^#?aw_[A-Za-z0-9]{3,8}$to allow optional#prefix - Updated field descriptions to document the optional
#prefix support
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compile-time schema (
pkg/workflow/js/safe_outputs_tools.json) rejected temporary IDs with leading#(e.g.,#aw_abc123), while the runtime schema and handler implementation accepted them. This caused validation failures for valid inputs.Changes:
draft_issue_idpattern:^aw_[A-Za-z0-9]{3,8}$→^#?aw_[A-Za-z0-9]{3,8}$temporary_idpattern:^aw_[A-Za-z0-9]{3,8}$→^#?aw_[A-Za-z0-9]{3,8}$#prefixBoth patterns now match the runtime schema (
actions/setup/js/safe_outputs_tools.json) and align with the handler's existing behavior:Addresses feedback: #16098 (comment)
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.