Clarify runtime-import path validation examples in templating docs#16133
Merged
Clarify runtime-import path validation examples in templating docs#16133
Conversation
Update templating.md to show two distinct security violation cases: - Relative traversal (../) attempting to escape .github folder - Absolute paths (/etc/passwd) which are not allowed Previously both examples were relative traversal with different depths. This improves clarity of security constraints for users. Fixes #16093 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Clarify runtime-import path validation examples in templating docs
Clarify runtime-import path validation examples in templating docs
Feb 16, 2026
pelikhan
approved these changes
Feb 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR clarifies the runtime-import path validation documentation by providing distinct examples for the two types of invalid paths that are rejected by the security validation logic. Previously, both invalid examples showed relative path traversal at different depths, obscuring the fact that absolute paths are also rejected.
Changes:
- Updated Path Validation section to show one relative traversal example (
../src/config.go) and one absolute path example (/etc/passwd) - Enhanced Error Handling section by splitting a single example into two labeled cases with distinct error scenarios
- Aligned examples with the two validation conditions in
runtime_import.cjs:relativePath.startsWith("..")ORpath.isAbsolute(relativePath)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The runtime-import path validation documentation showed two relative traversal examples (different depths) as invalid paths, obscuring that absolute paths are also rejected.
Changes
Updated
docs/src/content/docs/reference/templating.md:../../etc/passwd(relative traversal) to/etc/passwd(absolute path)../src/main.go/etc/passwdThe examples now map directly to the two validation conditions in
runtime_import.cjs:Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.