🔧 Fix Import Path Detection in Workflow Specification

[dsyme]

Summary

• Refined isWorkflowSpecFormat() to strictly check for workflow specifications using @ version separator
• Added comprehensive test cases for import path detection
• Improved git command execution with spinner support in various utility functions

Key Changes

• Updated import path detection logic to only consider paths with @ as workflow specifications
• Introduced new test cases covering various path scenarios in imports_test.go
• Added spinner support for git commands in workflow and repository-related operations
• Improved error handling and logging for git command executions

---

---

✨ PR Review Safe Output Test - Run 22075674041

💥 [THE END] — Illustrated by Smoke Claude

[pelikhan]

@dsyme any way to add integrations tests for this in ci.yml?

[Copilot]

Pull request overview

This PR refines import path detection to fix a bug where three-part relative paths (e.g., shared/mcp/arxiv.md) were incorrectly treated as workflowspecs. The fix simplifies the detection logic to only consider paths with @ version separators as workflowspecs, and adds comprehensive test coverage. Additionally, the PR introduces spinner support for git clone operations to improve user feedback during repository operations.

Changes:

• Simplified isWorkflowSpecFormat() to strictly check for @ version separator, fixing incorrect detection of three-part relative paths
• Added comprehensive unit and integration tests for import path detection
• Introduced RunGit() and RunGitCombined() helpers in pkg/workflow/git_helpers.go for git operations with spinner feedback
• Updated git clone operations in trial repository and package download flows to use spinner-enabled git helpers

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
pkg/cli/imports.go	Simplified isWorkflowSpecFormat() to only check for @ separator, removing complex path part counting logic
pkg/cli/imports_test.go	Added comprehensive test coverage for import path detection including edge cases
pkg/workflow/git_helpers.go	Added RunGit() and RunGitCombined() helpers with spinner support for interactive terminals
pkg/cli/trial_repository.go	Updated clone operations to use workflow.RunGitCombined() for spinner feedback
pkg/cli/packages.go	Added manual spinner management for git clone operations (inconsistent with trial_repository.go approach)

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.