Skip to content

Add CI validation for agent file URLs and enhance lock file checks #16232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 4 commits into from
Feb 16, 2026
Merged

Add CI validation for agent file URLs and enhance lock file checks #16232

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4890820
Initial plan
Copilot Feb 16, 2026
d05a45e
Add CI validation for agent file URLs and improve lock file check
Copilot Feb 16, 2026
28c1983
Merge branch 'main' into copilot/update-ci-checks-for-lock-validation
pelikhan Feb 16, 2026
dc84a2f
Merge branch 'main' into copilot/update-ci-checks-for-lock-validation
pelikhan Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -640,6 +640,11 @@ jobs:
# Find all .lock.yml files in the repository
LOCK_FILES=$(find . -type f -name "*.lock.yml" | sort)

if [ -z "$LOCK_FILES" ]; then
echo "⚠️ WARNING: No .lock.yml files found"
exit 0
fi

# Track if any release-compiled files are found
FOUND_RELEASE=0

Expand Down Expand Up @@ -680,6 +685,43 @@ jobs:

echo "✅ All lock files compiled with development build (no version in header)"

- name: Check agent file URLs use main branch
run: |
echo "🔍 Checking .github/agents/agentic-workflows.agent.md for correct branch URLs..."

AGENT_FILE=".github/agents/agentic-workflows.agent.md"

if [ ! -f "$AGENT_FILE" ]; then
echo "⚠️ WARNING: $AGENT_FILE not found, skipping check"
exit 0
fi

# Check for URLs that don't use 'main' branch
# Pattern matches: https://github.com/github/gh-aw/blob/{anything-except-main}/
# Uses negative lookahead to exclude 'main'
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment incorrectly states "Uses negative lookahead to exclude 'main'". The implementation uses grep -v (inverted match) to exclude lines containing /blob/main/, not a regex negative lookahead pattern. Consider updating the comment to accurately reflect the implementation, such as: "Uses grep -v to exclude lines containing '/blob/main/'".

Suggested change
# Uses negative lookahead to exclude 'main'
# Uses grep -v to exclude lines containing '/blob/main/'

Copilot uses AI. Check for mistakes.
INVALID_URLS=$(grep -n 'https://github.com/github/gh-aw/blob/' "$AGENT_FILE" | grep -v '/blob/main/' || true)

if [ -n "$INVALID_URLS" ]; then
echo "❌ ERROR: Found URLs not using 'main' branch in $AGENT_FILE"
echo ""
echo "Lines with invalid URLs:"
echo "$INVALID_URLS"
echo ""
echo "💡 All GitHub URLs in agent files must reference the 'main' branch!"
echo ""
echo "URLs should use the pattern:"
echo " https://github.com/github/gh-aw/blob/main/.github/aw/..."
echo ""
echo "To fix:"
echo " 1. Edit $AGENT_FILE"
echo " 2. Replace all 'blob/{commit-hash}/' or 'blob/{tag}/' with 'blob/main/'"
echo " 3. Commit the updated file"
echo ""
exit 1
fi

echo "✅ All URLs in $AGENT_FILE correctly use 'main' branch"

js:
runs-on: ubuntu-latest
needs: validate-yaml
Expand Down
Loading