-
Notifications
You must be signed in to change notification settings - Fork 312
Add pull-request-repo parameter to assign-to-agent for cross-repository PR creation
#16293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2068d5b
Initial plan
Copilot b647651
Add pr-repo parameter to assign-to-agent safe output
Copilot e0f30d2
Add pr-repo and allowed-pr-repos to JSON schema
Copilot 2e7b944
Add tests for pr-repo functionality and fix TypeScript errors
Copilot f4ce8eb
Rename pr-repo to pull-request-repo in field names
Copilot 9d6f683
Update safe outputs specification with pull-request-repo pattern
Copilot 38069dd
Fix validation to auto-allow pull-request-repo like target-repo pattern
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test sets both
GH_AW_AGENT_PULL_REQUEST_REPOandGH_AW_AGENT_ALLOWED_PULL_REQUEST_REPOSto the same repository value (line 1151-1152). This is inconsistent with the test pattern on lines 1105-1147 which verifies that the default repository is allowed even without an allowlist.If
pull-request-repois meant to follow the same pattern astarget-repo(where the configured value is automatically allowed), then this test should verify thatpull-request-repoworks WITHOUT needing to be listed inallowed-pull-request-repos. The test should only setGH_AW_AGENT_PULL_REQUEST_REPOand not setGH_AW_AGENT_ALLOWED_PULL_REQUEST_REPOS.Alternatively, if the intention is that
pull-request-repomust be explicitly listed in the allowlist, then:pull-request-repofails validation if not in the allowlistThis test needs to be updated to match the intended behavior and establish the correct pattern.