Skip to content

Fix missing global.context setup in submit_pr_review.test.cjs #16633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 3 commits into from
Feb 18, 2026
Merged

Fix missing global.context setup in submit_pr_review.test.cjs #16633

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32fab10
Initial plan
Copilot Feb 18, 2026
07140ff
Fix ReferenceError: context is not defined in submit_pr_review.test.cjs
Copilot Feb 18, 2026
90defa9
Merge branch 'main' into copilot/fix-github-actions-workflow-ab9ee377…
pelikhan Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions actions/setup/js/submit_pr_review.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,22 @@ const mockCore = {
},
};

const mockContext = {
eventName: "pull_request",
repo: {
owner: "test-owner",
repo: "test-repo",
},
payload: {
pull_request: {
number: 123,
head: { sha: "test-sha" },
},
},
};

global.core = mockCore;
global.context = mockContext;

const { createReviewBuffer } = require("./pr_review_buffer.cjs");

Expand All @@ -24,6 +39,21 @@ describe("submit_pr_review (Handler Factory Architecture)", () => {
beforeEach(async () => {
vi.clearAllMocks();

// Reset context to default for each test
global.context = {
eventName: "pull_request",
repo: {
owner: "test-owner",
repo: "test-repo",
},
payload: {
pull_request: {
number: 123,
head: { sha: "test-sha" },
},
},
};
Comment on lines +42 to +55
Copy link

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beforeEach redefines the full global.context object literal even though mockContext is already defined above. This duplicates the default context shape/values in two places and can drift over time. Consider resetting via a single source of truth (e.g., clone mockContext each time, or use a createMockContext() helper) to keep the defaults consistent while preserving test isolation.

Copilot uses AI. Check for mistakes.

// Create a fresh buffer for each test (factory pattern, no global state)
buffer = createReviewBuffer();

Expand Down
Loading