parser: add newline-stable frontmatter hash regression tests#17155
Merged
pelikhan merged 2 commits intogithub:mainfrom Feb 20, 2026
Merged
parser: add newline-stable frontmatter hash regression tests#17155pelikhan merged 2 commits intogithub:mainfrom
pelikhan merged 2 commits intogithub:mainfrom
Conversation
Contributor
Author
|
Implemented parser regression coverage for frontmatter hash stability across newline conventions.
Validation:
This contribution was informed by patterns from Gait: https://github.com/Clyra-AI/gait |
Contributor
|
Smoke test results for
Overall: PASS ✅
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Frontmatter hash comparisons can drift across LF vs CRLF content, which risks false cache misses and inconsistent workflow behavior across environments.
Why now
Cross-platform contributor workflows regularly mix newline conventions, and we need deterministic evidence that hashing remains stable.
What changed
TestComputeFrontmatterHash_LFAndCRLFMatch.TestComputeFrontmatterHash_ImportedFrontmatterLFAndCRLFMatch.Validation
go test ./pkg/parser -run "TestComputeFrontmatterHash_(LFAndCRLFMatch|ImportedFrontmatterLFAndCRLFMatch)" -count=1✅make agent-finish❌ baseline failure in existingpkg/workflowtests:TestGitPatchFromHEADCommitsTestGitPatchPrefersBranchOverHEADTestGitPatchNoCommitsRefs #17151