Remove overly strict neutralization of issue-closing keywords in PR bodies#17686
Closed
Remove overly strict neutralization of issue-closing keywords in PR bodies#17686
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…n PR bodies Issue-closing keywords like "Fixes #123" and "Closes #456" were being wrapped in backticks by neutralizeBotTriggers(), preventing GitHub from auto-closing issues when PRs were merged. This was too strict and made generated PRs less useful, so remove the filtering entirely from both output and input sanitization pipelines. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Investigate escaping of issue references in PR bodies
Remove overly strict neutralization of issue-closing keywords in PR bodies
Feb 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
neutralizeBotTriggers()was wrappingFixes #NN,Closes #NN,Resolves #NNetc. in backticks across the sanitization pipeline, converting them to inline code and breaking GitHub's auto-close behavior on merge.Changes
sanitize_content_core.cjs: RemoveneutralizeBotTriggers()call fromsanitizeContentCore()sanitize_content.cjs: RemoveneutralizeBotTriggersimport and call from the selective-mention pipeline pathsanitize_content,sanitize_output,compute_text, andcollect_ndjson_outputtests to expect passthrough behaviorBefore / After
Cross-repo reference restriction via
GH_AW_ALLOWED_GITHUB_REFS/neutralizeGitHubReferences()is unaffected and remains available for controlling whichowner/repo#Nreferences are allowed.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/github/gh-aw/contents/.github%2Fworkflows%2Faudit-workflows.md/opt/hostedtoolcache/node/24.13.0/x64/bin/node /opt/hostedtoolcache/node/24.13.0/x64/bin/node --conditions node --conditions development --experimental-import-meta-resolve --require /home/REDACTED/work/gh-aw/gh-aw/actions/setup/js/node_modules/vitest/suppress-warnings.cjs /home/REDACTED/work/gh-aw/gh-aw/actions/setup/js/node_modules/vitest/dist/workers/forks.js(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.